Createjoin game#64
Open
ZachBerman wants to merge 11 commits into
Open
Conversation
| def create | ||
| @game = Game.new | ||
| @game = Game.create | ||
| @game.white.update(user_id: current_user.id) |
Contributor
There was a problem hiding this comment.
What is this doing? IIRC there isn't a NVMwhite attribute on game
Contributor
There was a problem hiding this comment.
This is performing three db writes + a read, and is inefficient. The game should be created and populated with the player all in one fell swoop.
Contributor
|
Ahh cool works for me then 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Add functionality to create new game & join existing game
-Add stats to games#index
-Add username field