Open
Conversation
initial commit for this feature, already contains XML comments explaining all the public methods. Can use regex pattern matching or simple string matching to insert/replace text following Terminal's TextPostProcess method. Uses a delegate/event that is invoked on all TerminalTextModifier instances. Text is run thru each instance sequentially based on which instance was created first. I also added some test examples in DawnTesting.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework of PR #63 this adds a new class for modifying terminalnode displaytext following original Terminal.TextPostProcess method
Allows for two styles:
Regex vs Simple is determined by bool RegexPattern
In Simple you can then either replace OR insert after the matching string your IProvider value.
This can be applied to:
I've also added xml comments for everything public that was added this time (my bad for not doing this in earlier PRs lol)