Repository navigation
Offer pre-commit hooks - #12
Merged
Merged
Conversation
jevgate-system reviews the staged changes with the jevgate on PATH; jevgate builds it from source first. Both run check --base HEAD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Phase 3 of the roadmap:
.pre-commit-hooks.yamlwith two hooks that review the staged changes (jevgate check --base HEAD; pre-commit stashes unstaged changes first).jevgate-systemruns thejevgateon PATH (Homebrew, install.sh, cargo).jevgatehas pre-commit build JevGate from this repository with Rust.The README example pins
rev: v0.18.0, the first release that has the file.How it was checked
From a throwaway repository with a staged Python file,
pre-commit runpassed both hooks withargs: [--dry-run]: the Rust hook built JevGate from this commit, the system hook used a local build, and the dry run selected the staged file.