Put the npm package back in the install instructions - #45
Merged
Merged
Conversation
5327d33 left @tech-byte-frontier/jevgate out of the README, the install page, the privacy page and the CHANGELOG while it was not on npm. 0.30.0 is published there now, so this reverts it, keeping the gaming-guards entry as 0.30.0 worded it.
The publish step downloads the release's SHA256SUMS into npm/, and the launcher prefers a shipped copy. The test of a whole run served a fake release whose archive that copy does not list, so after the download it failed with exit 2 instead of the binary's 3. main now takes the shipped sums from its host like the rest, and the test passes none.
The launcher's download timeout was explained by an archive of about 7 MB; 0.30.0's are 8.7 to 10.5 MB, as the preview languages' grammars grew the binary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tech-byte-frontier/jevgate0.30.0 is on npm, published from the v0.30.0 tag'snpm/with the release'sSHA256SUMS. 5327d33 left the package out of the README, the install page, the privacy page and the CHANGELOG while it was unpublished; this puts those lines back.SHA256SUMShad been downloaded intonpm/to publish: the launcher prefers a shipped copy, and the test's fake archive is not listed in it.mainnow takes the shipped sums from its host like its other inputs, and the test passes none. What the package does is unchanged.Checked: the published tarball holds
README.md,SHA256SUMS(identical to the release's),bin/jevgate.js,lib/launcher.jsandpackage.json. Run from a scratch home, its first run downloaded and checked the aarch64-apple-darwin archive and printedjevgate 0.30.0in 2.3 s; the second took 0.6 s. The launcher tests pass with and without aSHA256SUMSinnpm/.