Skip to content

Mirror reviewed PR behaviour in colour scripts; record review and PR update - #6

Merged
TechLuddite merged 1 commit into
mainfrom
reviewed-colour-scripts
Sep 14, 2026
Merged

TechLuddite merged 1 commit into
mainfrom
reviewed-colour-scripts

Conversation

@TechLuddite

Copy link
Copy Markdown
Owner

Mirrors the adversarially reviewed behaviour now in omacom/omarchy#11626 (667b14c) into this repo's colour renderer and preparer: per-artwork colour handling, effect-list fallback when ttfx rejects it, and a strict SGR parameter grammar. Handoff docs record the PR update, the review findings, the Giants licence history check, and the cause of the two failed live launches. 27 tests pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Jp4VBCm2nK9qr2u3CrjttA

Per-artwork colour handling, an effect list that is dropped when ttfx
rejects it, and an SGR grammar check that refuses values above 255,
wrong 38/48 arity and long parameter lists. Handoff docs record the
draft PR update at 667b14c, the review findings, the licence check on
the Giants repository, and the cause of the failed live launches.

Claude-Session: https://claude.ai/code/session_01Jp4VBCm2nK9qr2u3CrjttA
@TechLuddite
TechLuddite merged commit dffbe50 into main Sep 14, 2026
0 of 2 checks passed
@TechLuddite
TechLuddite deleted the reviewed-colour-scripts branch September 14, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant