Repository navigation
Mirror reviewed PR behaviour in colour scripts; record review and PR update - #6
Merged
Merged
Conversation
Per-artwork colour handling, an effect list that is dropped when ttfx rejects it, and an SGR grammar check that refuses values above 255, wrong 38/48 arity and long parameter lists. Handoff docs record the draft PR update at 667b14c, the review findings, the licence check on the Giants repository, and the cause of the failed live launches. Claude-Session: https://claude.ai/code/session_01Jp4VBCm2nK9qr2u3CrjttA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the adversarially reviewed behaviour now in omacom/omarchy#11626 (667b14c) into this repo's colour renderer and preparer: per-artwork colour handling, effect-list fallback when ttfx rejects it, and a strict SGR parameter grammar. Handoff docs record the PR update, the review findings, the Giants licence history check, and the cause of the two failed live launches. 27 tests pass.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Jp4VBCm2nK9qr2u3CrjttA