refactor(proto): replace google.protobuf.Empty#6
Merged
faizanazim11 merged 1 commit intomasterfrom Oct 16, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the gRPC RefreshService API to remove dependency on google.protobuf.Empty and instead use a custom RefreshResponse message. This simplifies the codebase by eliminating external proto dependencies and ensures all Python code uses absolute imports for generated protobuf modules.
- Replaced
google.protobuf.Emptywith customRefreshResponsemessage in protobuf definitions - Updated all generated gRPC code to use the new response type and absolute imports
- Removed external protobuf dependency file and updated implementation code accordingly
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| protos/refresh.proto | Added custom RefreshResponse message and removed google.protobuf.Empty import |
| protos/google/protobuf/empty.proto | Removed external protobuf dependency file |
| src/tp_auth_serverside/pb/refresh_pb2.py | Regenerated protobuf classes with new RefreshResponse message |
| src/tp_auth_serverside/pb/refresh_pb2_grpc.py | Updated gRPC service stubs to use RefreshResponse and absolute imports |
| src/tp_auth_serverside/core/handler/refresh_handler.py | Updated to return RefreshResponse instead of Empty and fixed imports |
| pyproject.toml | Bumped version to 0.1.4 |
| .github/copilot-instructions.md | Updated documentation with environment setup and gRPC generation notes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the gRPC RefreshService API to remove its dependency on
google.protobuf.Emptyand instead use a customRefreshResponsemessage. This change simplifies the codebase, eliminates reliance on external proto files, and ensures all Python code uses absolute imports for generated protobuf modules. The update also bumps the package version to0.1.4.API and Protobuf Changes
google.protobuf.Emptyby deletingprotos/google/protobuf/empty.protoand updatingprotos/refresh.prototo define and use a customRefreshResponsemessage for theRefreshTokenRPC. [1] [2]refresh_pb2.pyandrefresh_pb2_grpc.pyto reflect the new response type, updating all serialization/deserialization logic and ensuring absolute imports for generated modules. [1] [2] [3] [4] [5]Python Implementation Updates
refresh_handler.pyto returnRefreshResponse()instead ofempty_pb2.Empty()and removed the import ofempty_pb2. [1] [2] [3]Documentation
.github/copilot-instructions.mdto clarify environment setup, gRPC code generation steps, the need for absolute imports, and the removal of external proto dependencies. [1] [2]Package Version
pyproject.tomlfrom0.1.3to0.1.4to reflect these API and implementation changes.