fix: share endpoint returns master.m3u8 for video stream URLs (#45)#48
Merged
Merged
Conversation
The /share/{token} asset overview built stream_url directly from
s3_key_processed, which is the HLS folder prefix for videos — leaving
viewers with a folder URL instead of the playlist. Mirror the existing
fix already applied in get_share_stream_url and assets.py.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/share/{token}so video assets receive a presigned URL ending in/master.m3u8instead of the HLS folder prefix.get_share_stream_url(share.py:1369) andassets.py:265.Closes #45.
Test plan
pytest apps/api/tests/test_share_video_stream.py— new tests fail before fix, pass afterpytest apps/api/tests/— full suite (54 tests) green🤖 Generated with Claude Code