Skip to content

Fix public share comments response handling#70

Merged
ravirajsinh45 merged 1 commit into
Techiebutler:mainfrom
GChaucer:fix/share-comments-response-shape
May 22, 2026
Merged

Fix public share comments response handling#70
ravirajsinh45 merged 1 commit into
Techiebutler:mainfrom
GChaucer:fix/share-comments-response-shape

Conversation

@GChaucer

Copy link
Copy Markdown
Contributor

Summary

  • Normalize public share comments responses on the single-asset share page
  • Support both the current bare array response and { comments: [...] } fallback shape
  • Keep behavior aligned with the folder share viewer

Fixes #67

Testing

  • corepack pnpm install --frozen-lockfile --ignore-scripts
  • corepack pnpm exec tsc --noEmit
  • corepack pnpm exec eslint 'app/share/[token]/page.tsx'

@ravirajsinh45 ravirajsinh45 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — minimal, well-scoped fix that correctly handles both response shapes the API returns. Backend inconsistency at comments.py:557 vs :567 is the real root cause; worth a follow-up to normalize, but the frontend handling here is defensive and correct.

@ravirajsinh45 ravirajsinh45 merged commit 67ec1c9 into Techiebutler:main May 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Single-asset public share: comments never render due to response-shape mismatch

2 participants