Fix public share comments response handling#70
Merged
ravirajsinh45 merged 1 commit intoMay 22, 2026
Conversation
ravirajsinh45
approved these changes
May 22, 2026
ravirajsinh45
left a comment
Contributor
There was a problem hiding this comment.
LGTM — minimal, well-scoped fix that correctly handles both response shapes the API returns. Backend inconsistency at comments.py:557 vs :567 is the real root cause; worth a follow-up to normalize, but the frontend handling here is defensive and correct.
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{ comments: [...] }fallback shapeFixes #67
Testing
corepack pnpm install --frozen-lockfile --ignore-scriptscorepack pnpm exec tsc --noEmitcorepack pnpm exec eslint 'app/share/[token]/page.tsx'