Repository navigation
Fix build errors in VideoPage and optimize Gradle memory - #1
Merged
Merged
Conversation
- Move LaunchedEffect for playbackSpeed after player declaration to resolve unresolved reference error - Optimize Gradle memory and JVM properties to prevent daemon OOM crashes Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Project assembly (
assembleDebug) failed due to two issues:VideoPage.ktfailed compilation withUnresolved reference 'player'becauseLaunchedEffect(player, playbackSpeed)referencedplayerbefore its declaration..gradle,app/build,.idea) were not ignored.Changes
VideoPage.kt: MovedLaunchedEffect(player, playbackSpeed)afterval player = pageState?.player.gradle.properties: Tuned JVM arguments (-Xmx1024m,-XX:+UseG1GC,-XX:CICompilerCount=2), limited Gradle max workers to 2, and explicitly setorg.gradle.java.hometo avoid daemon crashes and Java 25 incompatibilities..gitignore: Added.gitignoreto exclude Gradle caches, build directories, logs, and IDE files.Verification
./gradlew.bat assembleDebugsucceeds../gradlew.bat testDebugUnitTest --tests "com.snapreel.app.VideoPageTest"passes.