Skip to content

Create sample-board-pack.json for testing - #33

Merged
telivity-otaip merged 3 commits into
TelivityAI:mainfrom
GabrielCanalli:main
Aug 21, 2026
Merged

Create sample-board-pack.json for testing#33
telivity-otaip merged 3 commits into
TelivityAI:mainfrom
GabrielCanalli:main

Conversation

@GabrielCanalli

Copy link
Copy Markdown
Contributor

Summary

Type

  • Bug fix
  • Feature
  • Docs / deploy
  • Chore

Checklist

Added a sample board pack JSON file for testing purposes, including fictional job roles and stages.
Create sample-board-pack.json for testing
telivity-otaip added a commit that referenced this pull request Aug 21, 2026
Credit: @GabrielCanalli opened #33 — their fixture used the right demo companies but not the real board-pack shape, so Settings import loaded zero roles. This pack is produced via buildBoardPack.
@telivity-otaip

Copy link
Copy Markdown
Contributor

Thanks for jumping on #17, @GabrielCanalli — the fictional companies / SEEDED labeling were the right instinct.

Why we’re not merging this PR as-is: the fixture claims careerops-board-pack/v5 but uses a hand-rolled boards[] shape. Real packs from buildBoardPack put roles, accomplishments, contacts, etc. at the top level. Importing this file through importBoardPack yields 0 roles, so Settings → Import doesn’t populate the board.

Maintainer follow-up: we landed a corrected fixture (still crediting you) in a superseding PR — watch for the link once CI is up. Closing this one as superseded; #17 will close with that merge.

Appreciate the contribution.

@telivity-otaip telivity-otaip left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes

Not malicious — docs/fixture only. But it doesn’t improve the repo yet: JSON shape doesn’t match web/lib/board-pack.mjs, so import loads zero roles.

Maintainer is shipping a corrected fixture that credits @GabrielCanalli. Please prefer that path over iterating this branch unless you want to rebuild from buildBoardPack yourself.

@telivity-otaip

Copy link
Copy Markdown
Contributor

@GabrielCanalli — sorry for the earlier close; that was maintainer error. Reopened.

Your PR is the right vehicle for #17. The fixture just needs the real board-pack shape (roles / accomplishments at the top level from buildBoardPack), not a hand-rolled boards[] tree — otherwise Settings → Import loads 0 roles.

To let us push the corrected file onto this PR: please enable Allow edits from maintainers on this PR (checkbox in the right sidebar), then reply here. We’ll push the fixed docs/fixtures/sample-board-pack.json + docs/test onto your branch so you keep authorship.

If you’d rather DIY: regenerate with buildBoardPack from web/lib/board-pack.mjs (see also the corrected pack that was briefly on cursor/sample-board-pack-e9d6).

@telivity-otaip

Copy link
Copy Markdown
Contributor

@GabrielCanalli maintainer_can_modify is on — thank you.

We’re pushing the corrected pack onto this PR next (automation hit a GitHub App fork-push limit; maintainer will land it on your branch so you keep authorship).

Maintainer edit on TelivityAI#33. Replaces the hand-rolled boards[] fixture with a
buildBoardPack v5 pack so Settings → Import actually loads roles.

Co-authored-by: Gabriel Canalli Barbosa <gabrielcanalli9@gmail.com>
@telivity-otaip

Copy link
Copy Markdown
Contributor

Fixed on your branch — thanks again for opening this @GabrielCanalli. Real schema v5 pack is in place so Settings → Import actually populates roles. Merging once CI is green.

@telivity-otaip telivity-otaip left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review

Maintainer fix is on this PR now (19f66bb). Fixture is real buildBoardPack v5 shape — import loads roles. Docs + regression test included. Co-authored with @GabrielCanalli.

Malicious: none. Safe to merge once CI is green. Closes #17.

@telivity-otaip telivity-otaip self-assigned this Aug 21, 2026
@telivity-otaip
telivity-otaip merged commit 2e5c218 into TelivityAI:main Aug 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a public-safe sample board pack for Settings → Import demos

2 participants