Create sample-board-pack.json for testing - #33
Conversation
Added a sample board pack JSON file for testing purposes, including fictional job roles and stages.
Create sample-board-pack.json for testing
Credit: @GabrielCanalli opened #33 — their fixture used the right demo companies but not the real board-pack shape, so Settings import loaded zero roles. This pack is produced via buildBoardPack.
|
Thanks for jumping on #17, @GabrielCanalli — the fictional companies / SEEDED labeling were the right instinct. Why we’re not merging this PR as-is: the fixture claims Maintainer follow-up: we landed a corrected fixture (still crediting you) in a superseding PR — watch for the link once CI is up. Closing this one as superseded; #17 will close with that merge. Appreciate the contribution. |
telivity-otaip
left a comment
There was a problem hiding this comment.
Request changes
Not malicious — docs/fixture only. But it doesn’t improve the repo yet: JSON shape doesn’t match web/lib/board-pack.mjs, so import loads zero roles.
Maintainer is shipping a corrected fixture that credits @GabrielCanalli. Please prefer that path over iterating this branch unless you want to rebuild from buildBoardPack yourself.
|
@GabrielCanalli — sorry for the earlier close; that was maintainer error. Reopened. Your PR is the right vehicle for #17. The fixture just needs the real board-pack shape ( To let us push the corrected file onto this PR: please enable Allow edits from maintainers on this PR (checkbox in the right sidebar), then reply here. We’ll push the fixed If you’d rather DIY: regenerate with |
|
@GabrielCanalli maintainer_can_modify is on — thank you. We’re pushing the corrected pack onto this PR next (automation hit a GitHub App fork-push limit; maintainer will land it on your branch so you keep authorship). |
Maintainer edit on TelivityAI#33. Replaces the hand-rolled boards[] fixture with a buildBoardPack v5 pack so Settings → Import actually loads roles. Co-authored-by: Gabriel Canalli Barbosa <gabrielcanalli9@gmail.com>
|
Fixed on your branch — thanks again for opening this @GabrielCanalli. Real schema v5 pack is in place so Settings → Import actually populates roles. Merging once CI is green. |
telivity-otaip
left a comment
There was a problem hiding this comment.
Re-review
Maintainer fix is on this PR now (19f66bb). Fixture is real buildBoardPack v5 shape — import loads roles. Docs + regression test included. Co-authored with @GabrielCanalli.
Malicious: none. Safe to merge once CI is green. Closes #17.
Summary
Type
Checklist
web/config.jsnot committed)Closes Add a public-safe sample board pack for Settings → Import demos #17