fix(reports): occupancy and roomsSold use exclusive departure - #337
Merged
Conversation
getOccupancy occupied/stayovers and financial-summary roomsSold now require departure > report date, matching occupancy-trend and calendar room-nights, so sticky room.status / past-departure stayovers no longer inflate tonight occupancy. Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
telivity-otaip
marked this pull request as ready for review
August 21, 2026 03:35
PR added one reports.service stay-window test; CI check requires README/docs/test-stats.json to match the suite count. Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nest occupancy and financial-summary roomsSold ignored departure date, so sticky
rooms.status/ past-departure stayovers inflated tonight occupancy while Calendar and occupancy-trend correctly used exclusive departure.Changes
getOccupancy: occupied + stayovers from stay-window (arrival ≤ dateanddeparture > date).getFinancialSummaryroomsSold: same exclusive-departure filter (includeschecked_outfor historical nights, matching trend).Companion Cloud PR:
haip-cloudbranchcursor/staging-leftover-stay-window-5e13.Test plan
pnpm test -- src/modules/reports/reports.service.spec.ts(14 passing)