Skip to content

perf(train): release consumed grads at the optimizer-step boundary #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CjhHa1 merged 3 commits into from
Sep 17, 2026
Merged

perf(train): release consumed grads at the optimizer-step boundary #460

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38d8554
perf(train): release consumed grads at the optimizer-step boundary
Yuanjia-Lee Sep 14, 2026
696764c
chore(train): trim redundant grad-release commentary
CjhHa1 Sep 17, 2026
2ec5f22
Merge branch 'main' into perf/release-grads
CjhHa1 Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions unirl/train/backend/base_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,8 @@ def optimizer_step(self, *, max_grad_norm: float) -> float:
if self.ema is not None:
self.ema.step(self._optimizer_step_count)
self._optimizer_step_count += 1
# Release consumed grads before train-state offload.
self.optimizer.zero_grad(set_to_none=True)
return grad_norm

def on_rollout_end(self) -> None:
Expand Down
Loading