Repository navigation
refactor: rename residual DiffRL identifiers to UniRL - #498
Merged
Merged
Conversation
CjhHa1
requested review from
Jayce-Ping,
KemingWu,
Zcchill,
celve,
haonan3,
leviking98z-rgb and
zzhuoxin1508
as code owners
September 21, 2026 06:49
CjhHa1
force-pushed
the
rename/diffrl-to-unirl
branch
2 times, most recently
from
September 24, 2026 09:15
d258a53 to
87b7ab5
Compare
Old DIFFRL_* environment variables and socket/lock/shm paths are no longer recognized.
Remove the unused _unirl_param_checksums worker RPC, redundant int() on the int LoRA id constant, the unreachable adapter-name fallback, the NCCL mixin's load_weights fallback (every extension also mixes in BucketedIPCReceiveMixin), and a pointless import alias.
Generation requests already use UNIRL_LORA_NAME; vLLM and vllm-omni key adapters by lora_int_id, so this only aligns the registered name. The backend no longer takes adapter_name.
Every caller passes the int UNIRL_LORA_INT_ID; the id was coerced again in WeightSync, the backend, and the worker RPC.
CjhHa1
force-pushed
the
rename/diffrl-to-unirl
branch
from
September 30, 2026 09:00
ef4f4be to
fff0d9b
Compare
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DIFFRL_*env vars, socket/lock/shm paths, LoRA constants, worker RPC names, mixin helpers, and patch sentinels now useUNIRL_*/_unirl_*.DIFFRL_DISABLE_CUDNNis removed; only the existingUNIRL_DISABLE_CUDNNremains. LoRA adapter id stays1, serialize defaults stay on, replica rank still defaults to0._unirl_describe_params/_unirl_param_checksumsworker RPCs, redundantint()around the int LoRA id constant and the checksumadapter_id, the unreachablestr(adapter_name) or UNIRL_LORA_NAMEfallback, the NCCL mixin'sload_weightsfallback (every extension also mixes inBucketedIPCReceiveMixin), a pointless import alias, inlines the single-use parameter-module lookup into_unirl_loaded_param_checksums, and registers the vLLM-Omni LoRA underUNIRL_LORA_NAME(matching the generation request) so the backend no longer takesadapter_name.Related Issue
N/A. Follows #413 (merged); this branch is rebased onto current
main(fbbf829). The rebase conflict was inpatches/runtime.py: #474 deletedpatch_per_request_ar_seed, so the rename inside it was dropped.Test Plan
rg -n -i 'diffrl|diff_rl|diff-rl'is empty on the rebased treecollective_rpc/_call_rpccall sitepython3 -m compileallon the changed filesSKIP=no-commit-to-branch pre-commit run --from-ref <base> --to-ref HEADpassesdist.broadcastloads through_unirl_load_weights_unirl_loaded_param_checksumsand_unirl_loaded_lora_checksumson stub workers, run against the pre-PR implementation (git show <base>:...) on the same inputs: identical results for direct / empty-wrapper / no-module workers,nameshit / miss, top-level andmodel_runnerLoRA managers, and an unknown adapter idCompatibility / Risk
DIFFRL_*export (DIFFRL_IPC_DIR,DIFFRL_REPLICA_RANK,DIFFRL_MODEL_LOAD_SERIALIZE,DIFFRL_OMNI_BOOT_SERIALIZE,DIFFRL_DISABLE_CUDNN) must switch to theUNIRL_*name; old names are silently ignored.unirl-zmq-*.sock,/tmp/unirl_*.lock,unirl_weights_*); trainer and rollout must run the same revision.Reviewer Notes
The first commit is the mechanical rename; the follow-up commits are the cleanup and can be reviewed separately.
Pre-push review (independent reviewer: GPT-5.6 Sol, no findings):
int(adapter_id)was applied three times along the LoRA-checksum path (WeightSync, backend, worker RPC); every caller passes the intUNIRL_LORA_INT_ID.adapter_nameonWeightSync.set_lora_from_tensors*(it is theRolloutEngineinterface, also used by SGLang, and names the adapter in the wake-reload log/error);getattr(..., "_unirl_*", False)idempotency sentinels on monkey-patched callables.Checklist