Repository navigation
fix(dsh): expose drag and saved observation workflows - #520
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #513, #516 and #517: DSH currently cannot invoke the new drag/step/view capabilities, and
--match-texthelp suggests broader filtering than it provides.DSH now exposes
bsk_interactactionsdragandstep,bsk_inspect action=view, and sync saving/baseline/folding options. Live actions retain session ownership, queuing and observed-context checks. Offline views reject live session/context arguments. LiteralfindandmatchTextvalues use equals-form arguments so leading hyphens remain text.Failed and cancelled steps remain failed host results while retaining the complete CLI receipt for the model and Web client. A per-execution finalizer preserves completed-action evidence through the real DSH cancellation path, clears its receipt after use, and respects host policy blocks. The composite action is never retried. PTC callers receive failed receipts in the error message, and nested receipts also use the supported additional-context channel so cancellation cannot discard the model's evidence. On process exit, obsolete cancellation timers are cleared before the bounded output drain begins.
CLI help and references explain that
--match-textonly folds plain stateless numbered fallback buttons, preserving business text, named/stateful controls and forms/dialogs. General literal search is directed to savedview --find. The DSH skill still names all six tools and fits its LF/CRLF byte budget.The CLI wording and DSH integration are separate commits, followed by review fixes. Protocol and extension gesture/observation implementations are unchanged.
Validation:
ToolRuntime, SDK PTC bridge, and shipped default Web tool-card renderer; typecheck, build, Biome and repository npm package verification passed.view --find, and leading-hyphen literal parsing checks passed.