Repository navigation
docs(skill): explain closed and unconfirmable tab borrows - #526
Open
anhtahaylove wants to merge 1 commit into
Open
anhtahaylove wants to merge 1 commit into
anhtahaylove wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two borrow outcomes leave agents without a next step in the skill references:
confirmation_ui_unavailable: the CLI hint says to report it, but the agent cannot tell the user what to change.listConfirmationCandidatesinapps/extension/src/tools/borrow-confirmation.tsonly accepts the active tab of a normal, non-Agent window whose URL passesisInjectableContentScriptUrl(http/https, not an extension store). The new text says exactly that: ask the user to bring an ordinary http(s) page to the front of a user window, then retry once. It also notes that opening a tab does not help, since task tabs live in the Agent Window, which is excluded.not_foundontab borrow: the tab is gone. Agents tended to open a replacement tab and lose the logged-in state the task depended on. The new text asks them to have the user reopen it instead.Both the CLI skill and the DSH plugin skill get the same guidance, in each file's existing style. Docs only; no behavior change.
Context
We hit both outcomes running an agent on Windows: once no user window could host the prompt, and once a borrowed tab had been closed between steps. Without guidance the agent kept trying workarounds (new tabs, blank pages) instead of asking the user. These notes in our local copy of the skill fixed that.
Checks
node scripts/check-skill-bundles.mjs: both bundles validnode --test scripts/check-skill-bundles.test.mjs: 6/6 passnode scripts/check-crate-skill.mjs: passcargo test -p bsk --lib --test skill_install_legacy --locked skill_install: 51 + 5 passNote: on Windows those
skill_installtests read the real Hermes install whenHERMES_HOMEor%LOCALAPPDATA%\hermesexists, and fail if that copy has local edits. They pass once both are pointed at an empty directory. I left that alone here; happy to open a separate issue if useful.