Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The read-only
bsk networkcommand omits HTTP redirect responses. Chrome reports those inNetwork.requestWillBeSent.redirectResponse, rather than a separateresponseReceivedevent. The existing listener replaces the previous request's metadata without recording its response. A POST → 303 → GET workflow therefore loses the 303 and original POST in its network evidence; multi-hop redirects lose every intermediate response.Change
Record a redirect response through the existing bounded network buffer before replacing the request metadata. Preserve the old hop's method, the redirect's URL/status and event timestamp; keep subsequent response/failure attribution and incremental cursors intact. If capture begins mid-chain, the old method remains unknown instead of being misreported as the next request's method.
No protocol, permissions, request interception, or page-action behavior changes.
Verification
9cfba53582cb04d48da36aabd0a5017987d4daea: failed, returning no redirect entry instead of the POST/303 response.git diff --check: passed.--maxWorkers=2passed: 3,375 passed, 335 skipped (192 test files passed, 39 skipped). The original failure is retained here rather than attributed to an unproven cause.Tests drive the production ChromiumCdp event listener and buffer using the repository's debugger-API test double. No live Chrome/CLI round trip, Rust workspace tests, or full monorepo lint were run. The production build retains the existing large-chunk warning.
AI assistance
Prepared and tested with OpenAI Codex. Draft for maintainer review; no human-review attestation is claimed.