Conversation
steipete
marked this pull request as ready for review
August 28, 2026 15:49
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registerUserInFrameworkStorehas no production callers in this repository or the published 2.4.6 package. It is the only consumer of the deprecatedinfra-runtimefile-lock API. Remove that unused writer and its lock dependency instead of replacing it with a private SDK facade.Keep the existing allowlist reader and path resolver: message authorization still reads existing paired IDs, and account cleanup still owns deletion. This change does not write, delete, migrate, or change the precedence of stored authorization data. Replace writer-only tests with reader coverage for existing, missing, and malformed files, including assertions that reads leave the files untouched.
Independent follow-up to #251. No host minimum or dependency changes. This removes the file-lock dependency only; the authorization API migration remains separate because it must preserve sender admission and command authorization independently.
Validation at
d16f6e4: secretless Linux AWS proof with Node 24.19.0, the declared OpenClaw 2026.5.12 dependency, and install lifecycle scripts disabled. Typecheck, build, and all 393 tests passed; the six focused pairing tests also passed. The repository-wide coverage gate still fails: candidate branch coverage is 89.08% against 90%, while the unchanged parent also fails at 89.13% using the same dependency installation. No threshold or exclusion was weakened. Codex review and whitespace checks passed. No live Weixin session was used, and this change does not claim the separate authorization/storage migration is complete.