Skip to content

Persist aliases in database#88

Open
Faek wants to merge 1 commit into
Terminus-Project:masterfrom
Faek:master
Open

Persist aliases in database#88
Faek wants to merge 1 commit into
Terminus-Project:masterfrom
Faek:master

Conversation

@Faek

@Faek Faek commented Oct 9, 2015

Copy link
Copy Markdown

Aliases will be written and loaded from the database when the bot
starts, also added commands to list the aliases, and restore them if
they didn't load properly

Aliases will be written and loaded from the database when the bot
starts, also added commands to list the aliases, and restore them if
they didn't load properly
@kabaka

kabaka commented Dec 10, 2015

Copy link
Copy Markdown
Member

Thoughts:

  1. It would be better to use the :done_loading event rather than :em_started so that aliases are set if the script is loaded later. This would mitigate most of the need for the restorealiases command (except for cases wherein another script has altered the aliases).
  2. Should we then remove aliases on :unloaded? Seems like that would be wise.

Otherwise, this looks okay to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants