Fix Vivado detection on Windows for unwrapped installations (Fix #821)#848
Open
radami2006 wants to merge 1 commit intoTerosTechnology:devfrom
Open
Fix Vivado detection on Windows for unwrapped installations (Fix #821)#848radami2006 wants to merge 1 commit intoTerosTechnology:devfrom
radami2006 wants to merge 1 commit intoTerosTechnology:devfrom
Conversation
Issue TerosTechnology#821 reported that Vivado 2025.1 on Windows was not detected when users configured the unwrapped bin folder. Updated Vivado linter configuration validation to try multiple candidate binaries: xvhdl, xvlog, and vivado. This allows TerosHDL to validate more Vivado installation layouts, including paths where vivado.exe is not the executable used for linting. Closes TerosTechnology#821
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Vivado linter detection on Windows when the configured installation path points to unwrapped binaries and vivado.exe is not directly available.
Problem
In issue #821, TerosHDL failed Vivado configuration checks for valid Windows installations (Vivado 2025.1), reporting Vivado not found even though lint-capable binaries existed in the configured path.
Root cause
The configuration check only validated vivado, while actual lint execution may rely on xvhdl/xvlog depending on language and installation layout.
What changed
In src/colibri/linter/vivado.ts, this PR overrides checkLinterConfiguration to validate against a binary candidate list:
This uses existing binary checker utilities and keeps the rest of linter behavior unchanged.
Validation
Impact
Users configuring Vivado Windows paths that contain xvhdl/xvlog (but not a directly invokable vivado binary) should now pass linter configuration checks.