Fix grappling hook ladder death bug - #106
Merged
Merged
Conversation
Contributor
Author
|
I really do lol |
Member
Well thats good because I dont like making them lmao. Btw when you make a mixin I recommend adding the mods license to the top of the class like I did with the others. 99% of the time it wont be a problem but we dont want to risk curseforge taking the project down. |
Pyritie
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the new behavior?
Fixes #1647 on our side while my PR for Grappling Hook Reforged is reviewed
Implementation Details
I copied this fix from a PR from the original Grappling Hook mod. It adds an additional ladder check as well as resets fall distance on grapple release.
Outcome
Grappling hooks no longer kill you if you jump from one onto a ladder.
Additional Information
This apparently fixes other issues with how grappling hooks and gliders interact according to #123, so that's good?
Potential Compatibility Issues
If my PR gets accepted by the grapple mod author then this fix will become redundant and will need to be removed.