Skip to content

fix: sync generated files after Getopt::Yath extraction#304

Draft
Koan-Bot wants to merge 4 commits intoTest-More:2.0from
Koan-Bot:koan.atoomic/fix-getopt-yath-deps
Draft

fix: sync generated files after Getopt::Yath extraction#304
Koan-Bot wants to merge 4 commits intoTest-More:2.0from
Koan-Bot:koan.atoomic/fix-getopt-yath-deps

Conversation

@Koan-Bot
Copy link
Contributor

@Koan-Bot Koan-Bot commented Mar 12, 2026 •
edited
Loading

What

Sync Makefile.PL and cpanfile with dist.ini after Getopt::Yath was broken out into its own distribution.

Why

Commit 5be97a8 ("Break out Getopt::Yath") added Getopt::Yath = 2.000007 to dist.ini
but the generated files (Makefile.PL, cpanfile) were not regenerated. This causes CPAN
smoker failures with Can't locate Getopt/Yath/Settings.pm in @INC because the
dependency is not declared and therefore not installed.

Reported in PR #303 comments.

How

  • Added Getopt::Yath => "2.000007" to both PREREQ_PM and %FallbackPrereqs in Makefile.PL
  • Added requires "Getopt::Yath" => "2.000007" to cpanfile
  • Removed stale t/unit/Getopt/Yath/* test path patterns from the TESTS glob
    (test files were removed with the module extraction)

Note: The BoolMap class missing from CPAN Getopt::Yath 2.000007 is a separate
issue that requires a new Getopt::Yath release. This PR ensures the dependency is
at least properly declared.

Testing

Verified that dist.ini already declares this dependency — this PR brings the
generated files in sync with it.

🤖 Generated by Kōan

Quality Report

Changes: 1366 files changed, 102414 insertions(+), 24728 deletions(-)

Code scan: 224 issue(s) found

  • .gitignore:40 — TODO comment
  • README:607 — TODO comment
  • README:611 — TODO comment
  • README:615 — TODO comment
  • README.md:565 — TODO comment
  • README.md:569 — TODO comment
  • README.md:573 — TODO comment
  • demo/tiny/tiny.t:4 — XXX marker
  • deplib/App/Yath/Option.pm:21 — FIXME comment
  • deplib/App/Yath/Options.pm:22 — FIXME comment

Tests: failed (11 Failed, 390 Test)

Branch hygiene: clean

Generated by Kōan post-mission quality pipeline

@Koan-Bot
fix: sync generated files after Getopt::Yath extraction
943b4c5 
The "Break out Getopt::Yath" commit (5be97a8) added Getopt::Yath as a
dependency in dist.ini but the generated Makefile.PL and cpanfile were
not regenerated. This caused CPAN smoker failures:

  Can't locate Getopt/Yath/Settings.pm in @inc

Changes:
- Add Getopt::Yath 2.000007 to PREREQ_PM and FallbackPrereqs in Makefile.PL
- Add Getopt::Yath 2.000007 to cpanfile requires
- Remove stale t/unit/Getopt/Yath test paths from TESTS glob (files
  were removed with the module extraction)
@Koan-Bot
Copy link
Contributor Author

Koan-Bot commented Mar 12, 2026

Quality Gate Warning

Code issues found:

  • .gitignore:40 — TODO comment
  • README:607 — TODO comment
  • README:611 — TODO comment
  • README:615 — TODO comment
  • README.md:565 — TODO comment
  • README.md:569 — TODO comment
  • README.md:573 — TODO comment
  • demo/tiny/tiny.t:4 — XXX marker
  • deplib/App/Yath/Option.pm:21 — FIXME comment
  • deplib/App/Yath/Options.pm:22 — FIXME comment

Tests failed: FAILED

Auto-merge was skipped due to quality gate issues.

1 similar comment
@Koan-Bot
Copy link
Contributor Author

Koan-Bot commented Mar 12, 2026

Quality Gate Warning

Code issues found:

  • .gitignore:40 — TODO comment
  • README:607 — TODO comment
  • README:611 — TODO comment
  • README:615 — TODO comment
  • README.md:565 — TODO comment
  • README.md:569 — TODO comment
  • README.md:573 — TODO comment
  • demo/tiny/tiny.t:4 — XXX marker
  • deplib/App/Yath/Option.pm:21 — FIXME comment
  • deplib/App/Yath/Options.pm:22 — FIXME comment

Tests failed: FAILED

Auto-merge was skipped due to quality gate issues.

@atoomic
Copy link
Collaborator

atoomic commented Mar 13, 2026

view failures from smokers

1..2
PERL_HASH_SEED not set, setting to '20260312' for more reproducible results.
Can't locate object method "new" via package "Getopt::Yath::Option::BoolMap" (perhaps you forgot to load "Getopt::Yath::Option::BoolMap"?) at /usr/local/share/perl/5.38.2/Getopt/Yath/Option.pm line 89.
Compilation failed in require at lib/App/Yath.pm line 32.
BEGIN failed--compilation aborted at lib/App/Yath.pm line 32.
Compilation failed in require at lib/App/Yath/Script.pm line 12.
BEGIN failed--compilation aborted at lib/App/Yath/Script.pm line 12.
Compilation failed in require at /home/runner/work/Test2-Harness/Test2-Harness/scripts/yath line 20.
BEGIN failed--compilation aborted at /home/runner/work/Test2-Harness/Test2-Harness/scripts/yath line 22.
PERL_HASH_SEED not set, setting to '20260312' for more reproducible results.
Can't locate object method "new" via package "Getopt::Yath::Option::BoolMap" (perhaps you forgot to load "Getopt::Yath::Option::BoolMap"?) at /usr/local/share/perl/5.38.2/Getopt/Yath/Option.pm line 89.
Compilation failed in require at lib/App/Yath.pm line 32.
BEGIN failed--compilation aborted at lib/App/Yath.pm line 32.
Compilation failed in require at lib/App/Yath/Script.pm line 12.
BEGIN failed--compilation aborted at lib/App/Yath/Script.pm line 12.
Compilation failed in require at /home/runner/work/Test2-Harness/Test2-Harness/scripts/yath line 20.
BEGIN failed--compilation aborted at /home/runner/work/Test2-Harness/Test2-Harness/scripts/yath line 22.
not ok 1 - Passed tests when run by yath (allow fork)
not ok 2 - Passed tests when run by yath (no fork)
yath exited with 65280yath exited with 65280make: *** [Makefile:2660: test_dynamic] Error 255

@Koan-Bot
Copy link
Contributor Author

Koan-Bot commented Mar 13, 2026

Rebase: fix: sync generated files after Getopt::Yath extraction

Branch koan.atoomic/fix-getopt-yath-deps rebased onto 2.0 and force-pushed.

Diff: 3 files changed, 87 insertions(+), 1 deletion(-)

Review feedback was analyzed and applied.

Actions

  • Rebased koan.atoomic/fix-getopt-yath-deps onto origin/2.0
  • Applied review feedback
  • Force-pushed koan.atoomic/fix-getopt-yath-deps to origin

Automated by Kōan

@atoomic
Copy link
Collaborator

atoomic commented Mar 13, 2026

Still the same issue from smokers

@Koan-Bot
Copy link
Contributor Author

Koan-Bot commented Mar 13, 2026

Rebase: fix: sync generated files after Getopt::Yath extraction

Branch koan.atoomic/fix-getopt-yath-deps rebased onto 2.0 and force-pushed.

Diff: 3 files changed, 87 insertions(+), 1 deletion(-)

Review feedback was analyzed and applied.

Actions

  • Rebased koan.atoomic/fix-getopt-yath-deps onto origin/2.0
  • Applied review feedback
  • Force-pushed koan.atoomic/fix-getopt-yath-deps to origin

Automated by Kōan

@Koan-Bot
fix: use Settings->maybe() for orig_tmp in IPC dir fallback
66918b4 
When yath auto-detects the command (no explicit command given), it
creates an IPC object with partial settings from process_args(). These
partial settings lack 'orig_tmp' which is only set by
args_to_settings_data(). This causes a crash:

  The 'orig_tmp' option does not exist

Use Settings->maybe() with File::Spec->tmpdir() as fallback, matching
the same pattern used in Logger.pm's default sub.

This fixes 'make test' when Getopt::Yath is installed as an external
dependency (post Getopt::Yath extraction).
@Koan-Bot
Copy link
Contributor Author

Koan-Bot commented Mar 13, 2026

Analysis: root cause of smoker failure

The smoker error Can't locate object method "new" via package "Getopt::Yath::Option::BoolMap" is caused by a packaging bug in CPAN Getopt::Yath 2.000007: the shipped BoolMap.pm is missing its package declaration and use strict; line (first two lines truncated), so the class never gets defined in the correct namespace.

The BoolMap.pm in this PR (added to lib/) is a correct copy and will take precedence over the broken CPAN version via @INC ordering.

Additional fix: orig_tmp crash in IPC auto-detection

After adding the Getopt::Yath dependency and BoolMap.pm, make test still failed with:

The 'orig_tmp' option does not exist at .../Getopt/Yath/Settings/Group.pm

Root cause: test.pl runs yath -D test .... The -D (AutoPathList) option consumes test as its path argument, leaving no explicit command. Yath enters auto-detection mode, creating an IPC object with partial settings from process_args(). These partial settings don't include orig_tmp (only set by args_to_settings_data()), causing the crash.

Fix: Use $settings->maybe('yath', 'orig_tmp', File::Spec->tmpdir()) in IPC.pm instead of directly accessing orig_tmp. This matches the defensive pattern used in Logger.pm.

After this fix, make test successfully starts yath and runs the test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Koan-Bot @atoomic