fix: --rerun-failed without path now finds default lastlog.jsonl#305
Draft
Koan-Bot wants to merge 1 commit intoTest-More:masterfrom
Draft
fix: --rerun-failed without path now finds default lastlog.jsonl#305Koan-Bot wants to merge 1 commit intoTest-More:masterfrom
Koan-Bot wants to merge 1 commit intoTest-More:masterfrom
Conversation
…t-More#283) When --rerun-failed was used without an explicit log path, the $rerun variable stayed undef because the 'next if $val eq "1"' guard skipped setting it. This caused add_rerun_to_search() to never be called, so yath would run all tests instead of just the failed ones. The fix sets $rerun to '1' before the next, which triggers the lastlog.jsonl fallback path in Finder::add_rerun_to_search(). Closes Test-More#283
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
yath --rerun-failed(without an explicit log path) now correctly finds and uses./lastlog.jsonl.Why
When
--rerun-failedwas used without=path, the$rerunvariable stayedundefin_post_process()because anextguard skipped setting it when the option value was'1'(the default). This causedadd_rerun_to_search()to never be called, so yath ran all tests instead of just the failed ones.Reported in #283 with a clear reproduction case.
How
One-line fix in
Options/Finder.pm: set$rerun //= '1'before thenext, so the fallback inFinder::add_rerun_to_search()(which searches for./lastlog.jsonl) is triggered.Testing
t/integration/rerun_failed.t: runs yath with-Lto generate a lastlog, then runs--rerun-failedand verifies only the failed test is re-run.t/integration/failed.tandt/unit/App/Yath/Options.tstill pass.Closes #283
🤖 Generated with Claude Code
Quality Report
Changes: 4 files changed, 62 insertions(+), 1 deletion(-)
Code scan: clean
Tests: failed (timeout (120s))
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline