fix: forward include paths via PERL5LIB to child processes#307
Draft
Koan-Bot wants to merge 1 commit intoTest-More:masterfrom
Draft
fix: forward include paths via PERL5LIB to child processes#307Koan-Bot wants to merge 1 commit intoTest-More:masterfrom
Koan-Bot wants to merge 1 commit intoTest-More:masterfrom
Conversation
…#296) When yath runs tests, include paths (--lib, --blib, -I) were only passed as -I command-line flags to the test process. Child processes spawned via system($^X, ...) did not inherit these paths because -I flags don't propagate through process boundaries. This aligns yath with prove's behavior: include paths are now always set in PERL5LIB, ensuring child processes can find project modules. Fixes Test-More#296
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Always set
PERL5LIBwith project include paths (--lib,--blib,-I) for all test processes, not just binary/non-perl tasks.Why
When yath runs a test that spawns child Perl processes via
system($^X, ...), those children don't inherit the parent's-Iflags.prove -lavoids this by settingPERL5LIB, which is inherited by all child processes. Yath previously only setPERL5LIBfor binary/non-perl tasks, leaving normal Perl tests without environment-based include propagation.Fixes #296
How
Removed the
binary || non_perlguard on line 514 ofRunner/Job.pm::env_vars(). Include paths are now unconditionally added toPERL5LIBfor all task types, matchingprove's behavior.Testing
.txfiles) to reflect the new behaviorchild-inherits-inc.tx— spawns a child perl process and verifies it inherits project lib paths viaPERL5LIB🤖 Generated with Claude Code
Quality Report
Changes: 8 files changed, 60 insertions(+), 6 deletions(-)
Code scan: clean
Tests: failed (timeout (120s))
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline