Skip to content

elasticsearch destination add custom _id fallback for deduplication #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3meeb wants to merge 2 commits into
base: master
Choose a base branch
from
Open

elasticsearch destination add custom _id fallback for deduplication #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d14f87f
elasticsearch destination add custom _id fallback for deduplication
3meeb Jul 16, 2025
17c39b8
elasticsearch destination handle _id casing
3meeb Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion .../main/java/io/airbyte/integrations/destination/elasticsearch/ElasticsearchConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,18 @@ public BulkResponse indexDocuments(String index, List<AirbyteRecordMessage> reco
// TODO: Can we do something like this?
private String extractPrimaryKey(AirbyteRecordMessage doc, ElasticsearchWriteConfig config) {
if (!config.hasPrimaryKey()) {
// Check for _id field if no primary key is configured
// Try uppercase first (Snowflake default), then lowercase fallback
JsonPointer idPtr = JsonPointer.valueOf("/_ID");
var idNode = doc.getData().at(idPtr);
if (idNode.isMissingNode()) {
idPtr = JsonPointer.valueOf("/_id");
idNode = doc.getData().at(idPtr);
}
if (!idNode.isMissingNode() && idNode.isValueNode()) {
log.debug("using _id field value for document id");
return idNode.asText();
}
return UUID.randomUUID().toString();
}
var optFirst = config.getPrimaryKey().stream().findFirst();
Expand All @@ -196,7 +208,19 @@ private String extractPrimaryKey(AirbyteRecordMessage doc, ElasticsearchWriteCon
return pkNode.asText();
}
}
log.warn("unable to extract primary key");
log.warn("unable to extract primary key, checking for _id field");
// Check for _id field as fallback before random UUID
// Try uppercase first (Snowflake default), then lowercase fallback
JsonPointer idPtr = JsonPointer.valueOf("/_ID");
var idNode = doc.getData().at(idPtr);
if (idNode.isMissingNode()) {
idPtr = JsonPointer.valueOf("/_id");
idNode = doc.getData().at(idPtr);
}
if (!idNode.isMissingNode() && idNode.isValueNode()) {
log.debug("using _id field value for document id as fallback");
return idNode.asText();
}
return UUID.randomUUID().toString();
}

Expand Down