Conversation
Adds a logging middleware, and a contet helper. The context helper attaches arbitrary key/value attrs to contexts. The logging middleware adds any attributes attached to the context to logging messages as logging attributes.
Replace per-test global-sink-swap with a fan-out multiplex writer installed once on flume.Default(). Each Start() registers a subscriber and captures logs during its active window. Preserves nested-subtest semantics via lineage-aware suppression: a child Start() suppresses ancestor captures for its window. Verbose mode no longer live-streams to t.Log(); it now flushes captured logs on success (in addition to failure). Fixes parallel test log clobbering.
Does the same as Start(), with two changes: - no revert function is returned. Relies solely on t.Cleanup - returns a context, which, if passed to slog logging methods, will add the test name to the log's attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves support for parallel tests in v2: