Skip to content

Remove duplicate research source supplement #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erinepshovel-code merged 3 commits into from
Jul 25, 2026
Merged

Remove duplicate research source supplement #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96424a0
Remove duplicate research source supplement
erinepshovel-code Jul 25, 2026
9e78c4c
Remove duplicate supplement loader
erinepshovel-code Jul 25, 2026
d9c2984
Restore single research source authority
erinepshovel-code Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 0 additions & 45 deletions src/_data/research/source_supplements.yml
View file
Open in desktop

This file was deleted.

14 changes: 2 additions & 12 deletions src/_data/research_data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,20 +41,10 @@ async function readYamlList(path) {
return parsed;
}

async function readOptionalYamlList(path) {
try {
return await readYamlList(path);
} catch (error) {
if (error?.code === 'ENOENT') return [];
throw error;
}
}

export default async function researchData() {
const [sources, supplementalSources, claims] = await Promise.all([
const [sources, claims] = await Promise.all([
readYamlList('src/_data/research/sources.yml'),
readOptionalYamlList('src/_data/research/source_supplements.yml'),
readYamlList('src/_data/research/claims.yml')
]);
return { sources: [...sources, ...supplementalSources], claims };
return { sources, claims };
}
13 changes: 1 addition & 12 deletions tests/research-ledger.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,23 +25,12 @@ async function readYamlList(path) {
return parsed;
}

async function readOptionalYamlList(path) {
try {
return await readYamlList(path);
} catch (error) {
if (error?.code === 'ENOENT') return [];
throw error;
}
}

test('research ledgers parse and claims resolve to reviewed sources', async () => {
const [baseSources, supplementalSources, claims, articleLab] = await Promise.all([
const [sources, claims, articleLab] = await Promise.all([
readYamlList('src/_data/research/sources.yml'),
readOptionalYamlList('src/_data/research/source_supplements.yml'),
readYamlList('src/_data/research/claims.yml'),
readFile('src/_data/article_lab.json', 'utf8').then(JSON.parse)
]);
const sources = [...baseSources, ...supplementalSources];
assert.ok(Array.isArray(sources) && sources.length > 0);
assert.ok(Array.isArray(claims) && claims.length > 0);
assert.ok(Array.isArray(articleLab) && articleLab.length === 8);
Expand Down
Loading