Skip to content

Fix SITREP browser checks for supported fallback data - #67

Merged
erinepshovel-code merged 1 commit into
mainfrom
repair/sitrep-fallback-browser-count-20260907
Sep 7, 2026
Merged

erinepshovel-code merged 1 commit into
mainfrom
repair/sitrep-fallback-browser-count-20260907

Conversation

@erinepshovel-code

Copy link
Copy Markdown
Contributor

Post-merge review of #66 found that the browser fixture hard-coded the live 11-project count even though refresh:sitrep deliberately supports a committed last-known-good fallback that may contain a different project count.

This keeps the browser test at its declared presentation boundary: it now requires a non-empty rendered project set and exact navigation/card agreement, while tests/sitrep.test.mjs remains the contract that verifies the explicit 11-member core graph in the generator source.

Small scope: one Playwright fixture only; no authority, portfolio membership, refresh, or fallback semantics changed.

hmmm: a fallback snapshot may legitimately lag live portfolio membership; fallback=true keeps that incompletion visible.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T12:39:37.742156Z 9d089d2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@erinepshovel-code
erinepshovel-code merged commit 3955054 into main Sep 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant