Claude/fix inventory tokenization 2 k hr4 - #26
Conversation
The final round after the loop is always open (initiator's return never arrived before end-of-transcript). Replace the confusing 'open' if True else 'closed' ternary with a plain 'open' plus a clear comment. https://claude.ai/code/session_01Ya6yKBU13zpQ2BMy7iLnZc
- Backend/pyproject.toml: correct license from 'MIT' to 'Apache-2.0' (LICENSE file is Apache 2.0 since commit 791d7d5); update OSI classifier to match; add explicit 'dependencies = []' (stdlib-only package); fix sdist includes to use relative paths and include LICENSE - Backend/src/edcmbone/__init__.py: populate with __version__ = '0.1.0' and full public API re-exports from all submodules; add __all__ - Backend/LICENSE: copy root LICENSE into Backend/ so sdist include works - backend/ (lowercase): remove stale stub directory left from branch merge; it contained an incomplete pyproject.toml and placeholder parser; add backend/ to .gitignore to prevent reintroduction on case-insensitive filesystems https://claude.ai/code/session_01Ya6yKBU13zpQ2BMy7iLnZc
|
@copilot resolve the merge conflicts in this pull request |
|
@copilot resolve the merge conflicts in this pull request |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83191e3437
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tests/_artifacts/ | ||
|
|
||
| # Stale lowercase backend stub (canonical package lives in Backend/) | ||
| backend/ |
There was a problem hiding this comment.
The new backend/ ignore pattern is unanchored, so Git applies it to any directory named backend in the tree, not only the stale top-level stub. In this repo that also matches ammh/backend/, which means newly added files there will be silently ignored and easy to miss in commits. If the intent is only to ignore the root-level backend folder, anchor the rule as /backend/.
Useful? React with 👍 / 👎.
…ache-2.0 license fix and public API __init__.py to backend/ Co-authored-by: erinepshovel-code <250928284+erinepshovel-code@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR cleans up Python packaging/layout (removing an obsolete lowercase backend/ stub and formalizing the Backend/ package as the canonical build root), adds a top-level edcmbone package initializer for a consolidated public API, and clarifies round-finalization status handling in the core parsing pipeline.
Changes:
- Make the final round emitted by
core/parsing/round_builder.pyexplicitly"open"(removing a placeholder conditional). - Remove the old lowercase
backend/scaffold (including a placeholder parser file) and add a.gitignoreentry to prevent it from reappearing. - Update
Backend/pyproject.toml(license + sdist include paths) and addBackend/LICENSE; introduceBackend/src/edcmbone/__init__.pyto re-export the library’s public API.
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| core/parsing/round_builder.py | Removes a placeholder conditional and makes final-round status explicitly "open". |
| backend/src/edcmbone/parser/turns_rounds.py | Deletes an obsolete placeholder parser file in the removed lowercase stub tree. |
| Backend/src/edcmbone/init.py | Adds a package entrypoint that re-exports canon/parser/metrics symbols as the public API. |
| Backend/pyproject.toml | Switches project license metadata to Apache-2.0, adds explicit empty dependencies, and fixes sdist include paths. |
| backend/pyproject.toml | Removes obsolete lowercase packaging metadata. |
| Backend/LICENSE | Adds an Apache-2.0 license file for the Backend package distribution. |
| .gitignore | Ignores the stale lowercase backend/ directory to avoid future ambiguity. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| This license text was produced by the Apache Software Foundation for use in Apache projects. It is based on United States intellectual property laws. It is intended to provide permissive open source licensing for software and other creative works. For more information, see the Apache License FAQ at http://www.apache.org/foundation/license-faq.html. | ||
|
|
||
| Copyright [yyyy] [name of copyright owner] | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
| description = "Structural fidelity measurement for AI interactions — quantifies how much meaning an AI system deletes when transforming structured user input" | ||
| readme = "README.md" | ||
| license = { text = "MIT" } | ||
| license = { text = "Apache-2.0" } | ||
| requires-python = ">=3.8" | ||
| dependencies = [] | ||
| keywords = ["AI", "measurement", "structural fidelity", "cognitive accessibility", "NLP", "EDCM"] | ||
| classifiers = [ | ||
| "Development Status :: 3 - Alpha", | ||
| "Intended Audience :: Developers", | ||
| "Intended Audience :: Science/Research", | ||
| "License :: OSI Approved :: MIT License", | ||
| "License :: OSI Approved :: Apache Software License", | ||
| "Programming Language :: Python :: 3", |
Resolved in 7108be2. The conflicts arose from
|
The merge conflicts were already resolved in 7108be2. The branch is now cleanly ahead of |
No description provided.