Refresh canonical skill-lib snapshot - #15
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48d173bccf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ".rb": "#", ".rake": "#", ".gemspec": "#", | ||
| ".ex": "#", ".exs": "#", | ||
| ".sh": "#", ".bash": "#", ".zsh": "#", ".fish": "#", | ||
| ".pl": "#", ".pm": "#", ".t": "#", |
There was a problem hiding this comment.
When walk_tree scans a conventional Prolog .pl file, marker_for selects Perl's # marker, so valid Prolog % declarations are silently ignored and the module is reported as a coverage gap. This also conflicts with the newly documented rule that ambiguous suffixes are not auto-detected; remove .pl from automatic detection or provide a way for file-based callers to select Prolog explicitly, and mirror the correction in the TypeScript registry.
Useful? React with 👍 / 👎.
|
|
||
| The paired RATIOS helper preserves the interpreter boundary: a non-empty | ||
| line-1 shebang may precede opening RATIOS, which must then occupy line 2 with no | ||
| gap. See [`ratios/SKILL.md`](../ratios/SKILL.md) for the complete seal contract. |
There was a problem hiding this comment.
In this vendored snapshot, ../ratios/SKILL.md does not exist; a repo-wide search finds only this new reference, while the installed-skills list contains just meta-module-build, msdmd, and test-build. Readers therefore cannot access the promised complete seal contract, so vendor the RATIOS skill with this snapshot or make the required contract self-contained here.
Useful? React with 👍 / 👎.
| if not lines: | ||
| return (False, False) | ||
| first_ok = bool(line_re.match(lines[0].rstrip())) | ||
| has_shebang = lines[0].startswith("#!") and bool(lines[0][2:].strip()) |
There was a problem hiding this comment.
For a supported Rust file beginning with a standard inner attribute such as #![no_std], this check mistakes the attribute for an interpreter directive and accepts an opening RATIOS declaration on line 2; with RATIOS correctly on line 1 and the attribute on line 2, the new displaced-shebang check instead rejects it. This causes both false passes and false placement failures for Rust modules, so #![...] must be excluded from shebang detection in both parser implementations.
Useful? React with 👍 / 👎.
1 participant
Propagation
The-Interdependency/skill-libc14ee9d500579a4b5d6821f62c9d82ca96e73608The-Interdependency/eml_ucns6d55727cff7ac555034d3cbd8ade79a6042c9f51meta-module-build,msdmd,test-buildVerification
Generated files
eml_ucns_msdmd.tsDoctrine / hmmm
hmmm, not a claimed pass