Refresh canonical skill-lib snapshot - #4
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa03628aec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| `The-Interdependency/skill-lib`. | ||
|
|
||
| These directories are repo-local consumers. Canonical doctrine remains in skill-lib. | ||
| Source commit: `c14ee9d500579a4b5d6821f62c9d82ca96e73608` |
There was a problem hiding this comment.
The required preflight now encounters contradictory doctrine identities: this line says the vendored skills came from c14ee9d..., while docs/work-graph.json still identifies 8dfb974... as the “repo-local skill snapshot source,” and docs/graduation.json retains the same old dependency. The existing CI only verifies the stale graph's internal digest, so it still passes; update both current identity records and recompute the work-graph digest alongside this pointer.
AGENTS.md reference: AGENTS.md:L7-L8
Useful? React with 👍 / 👎.
| # The named-form computers above use Python imports, definitions, docstrings, | ||
| # and call syntax. Other parser-supported languages remain discoverable without | ||
| # becoming false strict-mode gaps or receiving Python-shaped verification. | ||
| COMPUTER_EXTENSIONS = {".py"} |
There was a problem hiding this comment.
When strict checking encounters an unsealed .pyw or .pyi file, the newly expanded parser registry discovers it, but this set classifies it as outside_computer_scope; consequently ratios_check.py --strict exits successfully with zero gaps. .pyw is ordinary Python source and these Python-oriented computers apply, so at least .pyw—and .pyi if its newly advertised support is intended—must be included for strict coverage and value verification.
AGENTS.md reference: AGENTS.md:L7-L7
Useful? React with 👍 / 👎.
| ".rb": "#", ".rake": "#", ".gemspec": "#", | ||
| ".ex": "#", ".exs": "#", | ||
| ".sh": "#", ".bash": "#", ".zsh": "#", ".fish": "#", | ||
| ".pl": "#", ".pm": "#", ".t": "#", |
There was a problem hiding this comment.
For conventional Prolog files named *.pl, parse_file now selects #, so valid % === ... === declarations are silently returned as an empty list and reported as gaps. Because .pl is shared by Perl and Prolog with different comment markers, this contradicts the applicable parser contract's rule to refuse ambiguous suffixes; omit automatic .pl detection or require the caller to provide the language/marker explicitly.
AGENTS.md reference: AGENTS.md:L7-L7
Useful? React with 👍 / 👎.
| "reason": f"no named-form computer for {path.suffix.lower()}", | ||
| } | ||
| ) | ||
| return |
There was a problem hiding this comment.
When a non-Python file has two differently valued boundary seals, this early return treats every value as merely unverifiable and exits successfully even though the updated contract requires the opening and closing lines to be identical. For example, a .ts file with loc_comments=1:1 at the top and loc_comments=999:999 at the bottom reports zero drift and zero misplacement; compare the raw boundary declarations for equality before taking the no-computer return path.
AGENTS.md reference: AGENTS.md:L7-L7
Useful? React with 👍 / 👎.
| def _has_valid_shebang(lines: list[str]) -> bool: | ||
| """Return whether literal line 1 is a non-empty interpreter directive.""" | ||
| return bool(lines and lines[0].startswith("#!") and lines[0][2:].strip()) |
There was a problem hiding this comment.
When the new shebang exception is used by a directly executable TypeScript file, _count_ts classifies the #! directive as program code rather than a comment-like interpreter directive. Thus stamping a file containing only #!/usr/bin/env -S npx tsx and one exported declaration emits N:M = 2:0, while the equivalent Python path counts its shebang on the comment side; strip or classify the recognized shebang consistently before computing TypeScript N:M.
AGENTS.md reference: AGENTS.md:L7-L7
Useful? React with 👍 / 👎.
1 participant
Propagation
The-Interdependency/skill-libc14ee9d500579a4b5d6821f62c9d82ca96e73608The-Interdependency/epacd8868858b2e455381ce670797bdbe47189bdc496a0p-instancing,action-calibration,agent-instantiation,canon,cap-build,char-compress,data-visualization,deps-build,distributed-publication,doc-build,domain-claims,epac-selection-display,explore-data,fresh-making,gonol-build,interdependent-work-graph,llms-build,loop-eng,manifest,meta,meta-module-build,msdmd,owner-build,plain-lens,project-incubation-graduation,ratios,repo-audit-repair,risk-boundary-build,skill-build,skill-usage,sql-queries,ssh-automation,statistical-analysis,test-build,the-interdependency,thought-lens,typed-meta-frontend,ucns-option-selection,validate-data,visitor-intro,vm-mcpVerification
hmmmretainedGenerated files
Doctrine / hmmm
hmmm, not a claimed pass