Refresh canonical skill-lib snapshot - #39
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 206a31efe2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| The paired RATIOS helper preserves the interpreter boundary: a non-empty | ||
| line-1 shebang may precede opening RATIOS, which must then occupy line 2 with no | ||
| gap. See [`ratios/SKILL.md`](../ratios/SKILL.md) for the complete seal contract. |
There was a problem hiding this comment.
The refreshed guide directs agents to ../ratios/SKILL.md for the complete seal contract, but the propagated skill set contains no ratios/ directory. Any metadata or behavior change involving RATIOS therefore reaches a dead link and cannot follow the repository’s required local-skill workflow; either include that skill in the vendored snapshot or keep the necessary guidance self-contained.
AGENTS.md reference: AGENTS.md:L12-L15
Useful? React with 👍 / 👎.
| ".tcc": "//", ".ipp": "//", ".inl": "//", | ||
| ".swift": "//", ".kt": "//", ".kts": "//", ".cs": "//", | ||
| ".mm": "//", ".scala": "//", ".dart": "//", ".zig": "//", | ||
| ".groovy": "//", ".gradle": "//", ".php": "//", |
There was a problem hiding this comment.
.php
When a RATIOS runner consumes this registry, a normal PHP source file cannot satisfy the advertised opening-boundary check: <?php must precede the // ratios: comment, while ratios_placement only allows the ratios line itself or a shebang on literal line 1. Consequently a PHP file with <?php on line 1 and the seal on line 2 always fails placement, whereas putting the comment before the opening tag emits it as response text; either recognize the PHP opening tag as a preamble or exclude .php from the shared registry.
Useful? React with 👍 / 👎.
| ".rb": "#", ".rake": "#", ".gemspec": "#", | ||
| ".ex": "#", ".exs": "#", | ||
| ".sh": "#", ".bash": "#", ".zsh": "#", ".fish": "#", | ||
| ".pl": "#", ".pm": "#", ".t": "#", |
There was a problem hiding this comment.
.pl files
The new guide says ambiguous suffixes must not be auto-detected, but .pl is used by both Perl and Prolog, whose line-comment markers are # and % respectively. Mapping every .pl file to # makes parse_file and walk_tree silently miss valid Prolog declarations and report those modules as gaps; remove .pl from automatic detection or provide a language-specific override instead of assuming Perl.
Useful? React with 👍 / 👎.
1 participant
Propagation
The-Interdependency/skill-libc14ee9d500579a4b5d6821f62c9d82ca96e73608The-Interdependency/pcea834987cb0c1fea5f62d6ea08e5c5bb878c312646manifest,meta-module-build,msdmd,test-buildVerification
Generated files
pcea_msdmd.tsDoctrine / hmmm
hmmm, not a claimed pass