Refresh canonical skill-lib snapshot - #19
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c5bd4d05ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # extension → line-comment marker. Keep this registry entry-for-entry equivalent | ||
| # to universal.ts; tests fail if either parser gains or loses an extension alone. | ||
| COMMENT_MARKERS: dict[str, str] = { |
There was a problem hiding this comment.
This public registry and the new shebang-placement semantics materially revise the parser, but neither this module nor the other changed executors adds the required MODULE_BUILD and CONTRACTS declarations or paired CHECKS evidence. Add those declarations and executable evidence so the new extension and placement behavior is represented in the repository's metadata audit.
AGENTS.md reference: AGENTS.md:L45-L49
Useful? React with 👍 / 👎.
| ".rb": "#", ".rake": "#", ".gemspec": "#", | ||
| ".ex": "#", ".exs": "#", | ||
| ".sh": "#", ".bash": "#", ".zsh": "#", ".fish": "#", | ||
| ".pl": "#", ".pm": "#", ".t": "#", |
There was a problem hiding this comment.
.pl marker detection
Do not map .pl unconditionally to #: .pl is also a conventional Prolog suffix, where the line-comment marker is %. For such a file, marker_for() selects the Perl marker, so parse_file() silently ignores valid % === ... === blocks and walk_tree() reports a false coverage gap; leave the suffix unresolved and require an explicit marker, as the parser already does for other ambiguous suffixes.
Useful? React with 👍 / 👎.
| # The named-form computers above use Python imports, definitions, docstrings, | ||
| # and call syntax. Other parser-supported languages remain discoverable without | ||
| # becoming false strict-mode gaps or receiving Python-shaped verification. | ||
| COMPUTER_EXTENSIONS = {".py"} |
There was a problem hiding this comment.
Include .pyi and .pyw in the Python computer scope. Both extensions are newly registered as Python, but this set routes them to outside_computer_scope; consequently --strict succeeds when their seals are missing, and even deliberately drifted seals are reported only as unverifiable despite the existing Python metric computers being applicable.
Useful? React with 👍 / 👎.
| working = _strip_seal(lines, ext) | ||
| new = "\n".join([want] + working + [want]) + "\n" | ||
| if _has_valid_shebang(working): | ||
| new_lines = [working[0], want, *working[1:], want] |
There was a problem hiding this comment.
When --write handles a Node TypeScript executable, this path preserves its #! line while _count_ts() classifies that line as code rather than as a hashbang comment. A script containing a hashbang and one statement is therefore stamped with N:M = 2:0 instead of 1:1, making the canonical density metric inaccurate for every .ts or .tsx executable using the newly supported shebang placement.
Useful? React with 👍 / 👎.
| ".swift": "//", ".kt": "//", ".kts": "//", ".cs": "//", | ||
| ".mm": "//", ".scala": "//", ".dart": "//", ".zig": "//", | ||
| ".groovy": "//", ".gradle": "//", ".php": "//", |
There was a problem hiding this comment.
Do not route .php files through the generic boundary-placement check without a PHP-aware preamble rule. A valid PHP file begins with <?php, so a named seal immediately after that tag is always reported as misplaced; moving the // ratios: seal to literal line 1 instead places it outside PHP and can emit the annotation in an HTTP response or trigger headers-already-sent failures. Either exclude PHP from RATIOS scanning or treat the opening tag as a required language boundary.
Useful? React with 👍 / 👎.
1 participant
Propagation
The-Interdependency/skill-libc14ee9d500579a4b5d6821f62c9d82ca96e73608The-Interdependency/ptcna7435cd4ce676b437656c50e874b6525e84d384d9canon,interdependent-work-graph,meta-module-build,msdmd,ratios,risk-boundary-build,skill-usage,test-build,the-interdependencyVerification
Generated files
Doctrine / hmmm
hmmm, not a claimed pass