Add 5-repo audit bundles and private operator access - #13
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bbe6dba23f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| except subprocess.TimeoutExpired: | ||
| audits.append({"repo_url": repo_url, "error": "repository audit timed out"}) | ||
| except subprocess.CalledProcessError: | ||
| audits.append({"repo_url": repo_url, "error": "repository could not be cloned"}) |
There was a problem hiding this comment.
When any repository in a paid bundle times out or fails to clone, run_audit_batch converts that failure into a normal result item, so /paid still returns 200; the hosted UI then labels all requested audits “complete” and removes the checkout session ID from the URL. A customer can therefore pay for five audits, receive fewer than five after a transient failure, and lose the only retry handle. Propagate a failed paid batch as non-success or persist/retry incomplete items before clearing the session.
AGENTS.md reference: AGENTS.md:L33-L33
Useful? React with 👍 / 👎.
| if len(set(repo_urls)) != len(repo_urls): | ||
| raise ValueError("duplicate repository URLs are not allowed") |
There was a problem hiding this comment.
The uniqueness check compares raw strings, so a five-repository bundle can include the same repository more than once using equivalent spellings such as https://github.com/owner/repo and https://GITHUB.COM/owner/repo. Both pass validation but clone the same target, causing a customer who intended five distinct audits to pay for duplicate output. Normalize at least the host and redundant repository-path forms before checking uniqueness.
Useful? React with 👍 / 👎.
| success_url = os.environ.get("PUBSKILL_SUCCESS_URL", DEFAULT_SUCCESS_URL) | ||
| cancel_url = os.environ.get("PUBSKILL_CANCEL_URL", DEFAULT_CANCEL_URL) | ||
| form = [ | ||
| ("mode", "payment"), | ||
| ("success_url", success_url), |
There was a problem hiding this comment.
When PUBSKILL_SUCCESS_URL is set to an ordinary deployment URL without {CHECKOUT_SESSION_ID}, Checkout can accept payment but returns the browser without a session ID. The page only invokes loadPaid when the session_id query parameter exists, and there is no webhook or other fulfillment path, so the customer receives no audit. Validate that an override contains the placeholder or construct the session-bearing return URL from a configured base URL.
Useful? React with 👍 / 👎.
1 participant
Implements the next hosted Audit surface while preserving the two-choice product rule.
PUBSKILL_OPERATOR_CODE; the code is never committed or stored in browser state.HOSTED.mddocumenting the hosted contract and unresolved Examiner boundary.Stripe product now has explicit active prices for $5 single audit and $20 five-repo bundle. Hosted Examiner remains hmmm pending real metering.