Repair audited v0.2 release blockers by erinepshovel-code · Pull Request #4 · The-Interdependency/pubskill-lib

erinepshovel-code · 2026-09-11T00:42:11Z

The examiner could overwrite concurrent edits, rewrite literal source data as metadata, lose encoding or inode metadata, and misidentify direct package-script dependencies. This repair preserves canonical source boundaries, keeps unsupported mutations explicit as hmmm, and bounds script inspection to supported literal interpreter invocations.

Source publication retains the original inode and creates the new name only if absent. Ownership, mode, ACLs, and xattrs are verified before publication; recovery paths are reported. After application, assembly re-inventories the source so concurrent edits can mark old narratives stale. README documents the brief absent-name interval and already-open writer limits.

Validation at 1b52d085a5c6bae3808727408c5795a4ff684770: all 73 tests pass; all 73 also passed after applying the examiner to a copied real repository at the preceding head (62f863a). Python 3.11/3.12 CI and CodeQL pass. Regressions cover option arity and shell context, literal filename characters, source encodings and hash failures, source races, metadata preservation, and stale narrative assembly. All reported findings are resolved. Exact-head review completed with no major issues at 05:01 UTC; the final tilde regression and all 73 tests pass. This maintenance PR creates no tag or release.

chatgpt-codex-connector · 2026-09-11T00:42:20Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-12T05:01:13.807139Z	`1b52d08`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

erinepshovel-code · 2026-09-11T00:43:55Z

@codex review

Please review exact head 3a2f415d839930703dc9b86c1c8d0e17dfa86707, especially credential/base-URL trust boundaries, msdmd/RATIOS/NARRATIVE source-boundary placement, canonical marker loading, package-script path handling, and release/provenance truthfulness.

erinepshovel-code · 2026-09-11T00:45:56Z

@codex review

Exact-head refresh after final audit-boundary correction: a7976df733b428b93ba0db921980be23c23db57e. CI is green on Python 3.11 and 3.12.

erinepshovel-code · 2026-09-11T00:48:47Z

@codex review

Final exact-head review: fbc38422ddee2a28f2ba1e4dd4eccda3a6a69f93. The handoff was restored to preserve original operational detail; only evidenced contract corrections remain.

erinepshovel-code · 2026-09-11T00:52:01Z

@codex review

Final exact-head review requested for 78e397e1e0598b5331944f42d2cb0a1fd9445c14. Please include the new examiner self-staleness/idempotence repair in review scope.

erinepshovel-code · 2026-09-11T00:54:14Z

@codex review

Exact-head review requested for c7b2f05c77562d46430ceb1b72316a88477ef9d8. The previous red CI localized a parser defect: numeric field names such as evidence_sha256 were silently dropped; the parser grammar now retains lowercase snake-case fields containing digits. The idempotence regression remains unchanged.

erinepshovel-code · 2026-09-11T00:56:27Z

@codex review

Exact-head review requested for a1681cff1014aadc1ff84e81538850ca08a4b318. Prior red runs were used as evidence and repaired without weakening the idempotence test; CI action deprecations and token over-permission surfaced in those logs were also repaired.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a1681cff10

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e7c7010d1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

erinepshovel-code · 2026-09-12T03:01:07Z

@codex review

Review exact head 25f65b5b564a3b3a439de4ee938453f95da5892c. The four new findings are repaired: Node inspect subcommands select their script (remote/PID attaches excluded); decoded malformed paths remain hmmm without aborting the audit; only metadata at reserved source boundaries is removed, including during writes; source is rechecked after provider calls and before atomic publication. All 60 tests pass, including multiline literal preservation, concurrent edits, failed writes, and hardlinks. A copied real repository also passes all 60 tests after running the actual examiner --apply against itself.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 25f65b5b56

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 25f65b5b56

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

erinepshovel-code · 2026-09-12T03:20:37Z

@codex review

Review exact head 53e509f73c09a45d6f90a1ecdf16a52ab1de4aa2. All 62 tests pass. Publication now withdraws the original into a private, retained recovery inode and atomically links the candidate only if the live name remains absent. It never replaces a competing live path; already-open writers retain their inode, and the report identifies recovery paths. Forced competing publication and late open-fd writes are tested. The brief absent-name interval and nontransactional concurrency boundary are explicit in README. Also fixed inspect option arity, malformed URL escapes, leading shell assignments, adapterless hmmm, and ordinary URL-shaped file operands.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 53e509f73c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

erinepshovel-code · 2026-09-12T03:36:34Z

@codex review

Please review 363e398b7759412f143b322ff6bb2a052424af21 after the final three findings. All 64 tests pass. CLI text and JSON now expose recovery paths; hard-link support for both publication and restoration is checked before withdrawing source. RATIOS placement is validated by the unmodified, pinned canonical parser: a conflicting protected coding-cookie prologue remains untouched with explicit hmmm in both plan and apply. This consumer no longer publishes the expanded placement rejected by canonical doctrine; no canonical contract or pin was changed. The ordinary shebang idempotence test now asserts canonical placement, while dedicated encoding-cookie regressions assert preservation and explicit noncoverage.

erinepshovel-code · 2026-09-12T03:39:16Z

@codex review

Exact-head refresh: 660d2c808c52b746a8a3543bbff563dea99aa8df. The only delta from 363e398 makes two CLI regressions create a fresh source file, so recovery reporting is still exercised when the copied fixture already has valid RATIOS. Production code is unchanged; all 64 tests pass. Please review the final head including the previously described three repairs.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 660d2c808c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 660d2c808c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

erinepshovel-code · 2026-09-12T04:03:30Z

@codex review

Review exact head 751dbd866a6658cb4fbd95276c473639eceb6e98. All 69 tests pass, including all 69 against a copied real repository after --apply. The nine findings are repaired: canonical preservation requires the exact relative path and canonical bytes; assembly re-inventories after mutation/skips; interpreter exit options stop file selection; shell comments are respected; failed candidate setup cleans recovery storage; Linux ownership/mode/ACL/xattr metadata is copied and verified before publication; malformed quoting, unsupported commands/option arity, and directory transitions remain hmmm; path-qualified supported interpreters are recognized. Tests reproduce each case, including live concurrent edit plus stale narrative rendering, xattr preservation/refusal, and failed candidate setup. No canonical contract expansion is introduced.

chatgpt-codex-connector · 2026-09-12T04:06:43Z

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 751dbd866a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

erinepshovel-code · 2026-09-12T04:15:35Z

@codex review

Please review exact head 5b0f03fc95d48416db803040e7017682cea15969. The preceding 751dbd8 received a clean review. This delta makes unsupported shell expansion, globs, subshells, redirections, and escaped newlines explicit hmmm instead of treating their text as literal paths; single-quoted and escaped literal characters remain supported. All 69 tests pass and CI is green. No other production changes.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b0f03fc95

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

erinepshovel-code · 2026-09-12T04:24:37Z

@codex review

Review exact head e065432294f705317e7825d397b09d8f76f0e247. All 70 tests pass. The three distinct findings (four threads, one duplicate) are repaired: literal entrypoints survive unsupported trailing arguments, non-leading tildes remain literal, and uncertainty in a supported child's arguments does not change the parent working-directory state. Structural shell syntax still leaves later context unresolved. Regressions include Node/Python trailing variables, -- delimiter, quoted command substitution, internal/leading tildes, dynamic/glob first targets followed by literal commands, and a structural substitution that must not leak nested targets.

chatgpt-codex-connector · 2026-09-12T04:25:17Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Unknown error

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

erinepshovel-code · 2026-09-12T04:25:56Z

@codex review

Review exact head e065432294f705317e7825d397b09d8f76f0e247. All 70 tests pass. The three distinct findings (four threads, one duplicate) are repaired: literal entrypoints survive unsupported trailing arguments, non-leading tildes remain literal, and uncertainty in a supported child's arguments does not change the parent working-directory state. Structural shell syntax still leaves later context unresolved. Regressions include Node/Python trailing variables, -- delimiter, quoted command substitution, internal/leading tildes, dynamic/glob first targets followed by literal commands, and a structural substitution that must not leak nested targets.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e065432294

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

erinepshovel-code · 2026-09-12T04:46:52Z

@codex review

Please review exact head 62f863ad92e5daa44b1db58c2813035b6c58bc93. All 73 tests pass. The five findings are repaired: assignment-position tilde expansion stays unresolved while internal/non-assignment tildes remain literal; supported fixed-arity option values with quoted scalar expansions preserve following literal entrypoints (including attached/clustered forms); already shell-decoded filenames retain literal quote characters; Unicode encoding failures during stable hashing retain raw-byte evidence and disable mutation; Bash +s/+es are stdin modes. Regression coverage includes full audit presence/absence checks for quote-named files and both dry-run/apply for the surrogate-producing coding cookie.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 62f863ad92

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

erinepshovel-code · 2026-09-12T04:57:35Z

@codex review

Please review exact head 1b52d085a5c6bae3808727408c5795a4ff684770. The sole new finding is fixed: assignment tilde recognition applies after the first NAME= separator or later colons, while a later =~ remains literal. The regression includes entry=value=~/missing.js. All 73 tests pass. Other runtime behavior is unchanged from 62f863a, which also passed all 73 tests after --apply to a copied real repository.

chatgpt-codex-connector · 2026-09-12T05:01:12Z

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 1b52d085a5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

repair: close audit defects before v0.2.0

0753156

repair: align documentation and provenance guards

3a2f415

repair: remove stale hmmm and keep legal surface unchanged

a7976df

repair: preserve handoff scope and public claims

fbc3842

repair: make examiner metadata idempotent

78e397e

repair: retain numeric msdmd narrative fields

c7b2f05

repair: make narrative upsert idempotent and harden CI

a1681cf

chatgpt-codex-connector Bot reviewed Sep 11, 2026

View reviewed changes

erinepshovel-code added 11 commits September 11, 2026 05:34

fix: treat blank model overrides as unset

1373ea4

fix: mutate only safe ratio languages

e528267

fix: close package-script audit gaps

5085f77

test: cover repaired audit and examiner boundaries

b0b6afa

chore: repin canonical msdmd parser

90c55d7

chore: align TypeScript parser with canonical msdmd

953765e

chore: preserve canonical parser bytes

e82f925

chore: refresh canonical msdmd skill

edc29c0

docs: pin merged skill-lib authority

76fa080

docs: record refreshed canonical skill source

cc2e8ca

fix: consume canonical msdmd entry parser

4e7c701

chatgpt-codex-connector Bot reviewed Sep 11, 2026

View reviewed changes

erinepshovel-code added 3 commits September 11, 2026 05:59

fix audit interpreter and path boundaries

3d52e9f

package canonical msdmd parser

3b9162d

fix evidence packaging and byte hashing

d307e28

chatgpt-codex-connector Bot reviewed Sep 12, 2026

View reviewed changes

Comment thread src/pubskill_lib/msdmd_writer.py Outdated

Comment thread src/pubskill_lib/audit.py Outdated

Comment thread src/pubskill_lib/audit.py

chatgpt-codex-connector Bot reviewed Sep 12, 2026

View reviewed changes

Comment thread src/pubskill_lib/audit.py Outdated

Comment thread src/pubskill_lib/examine.py

Comment thread src/pubskill_lib/audit.py Outdated

Preserve source inodes and publish without replacing competing edits

53e509f

chatgpt-codex-connector Bot reviewed Sep 12, 2026

View reviewed changes

Comment thread src/pubskill_lib/examine.py

Comment thread src/pubskill_lib/source_boundaries.py

Comment thread src/pubskill_lib/msdmd_writer.py

Enforce canonical placement and expose safe source recovery

363e398

Keep recovery CLI regressions valid after fixture annotation

660d2c8

chatgpt-codex-connector Bot reviewed Sep 12, 2026

View reviewed changes

Comment thread src/pubskill_lib/examine.py Outdated

Comment thread src/pubskill_lib/examine.py

Comment thread src/pubskill_lib/audit.py

Comment thread src/pubskill_lib/audit.py

Comment thread src/pubskill_lib/msdmd_writer.py Outdated

chatgpt-codex-connector Bot reviewed Sep 12, 2026

View reviewed changes

Comment thread src/pubskill_lib/msdmd_writer.py Outdated

Comment thread src/pubskill_lib/audit.py

Comment thread src/pubskill_lib/audit.py Outdated

Comment thread src/pubskill_lib/audit.py

Close audit context gaps and preserve source metadata and stale evidence

751dbd8

Keep unresolved shell expansion contexts out of literal path findings

5b0f03f

chatgpt-codex-connector Bot reviewed Sep 12, 2026

View reviewed changes

Comment thread src/pubskill_lib/audit.py Outdated

Comment thread src/pubskill_lib/audit.py Outdated

Comment thread src/pubskill_lib/audit.py Outdated

Comment thread src/pubskill_lib/audit.py Outdated

Keep literal entrypoints visible around dynamic child arguments

e065432

chatgpt-codex-connector Bot reviewed Sep 12, 2026

View reviewed changes

Comment thread src/pubskill_lib/audit.py Outdated

Comment thread src/pubskill_lib/audit.py Outdated

Comment thread src/pubskill_lib/audit.py Outdated

Comment thread src/pubskill_lib/evidence.py Outdated

Comment thread src/pubskill_lib/audit.py

Close shell operand and undecodable evidence hash gaps

62f863a

chatgpt-codex-connector Bot reviewed Sep 12, 2026

View reviewed changes

Comment thread src/pubskill_lib/audit.py Outdated

Restrict assignment tilde expansion to its first separator or colons

1b52d08

erinepshovel-code merged commit b03828e into main Sep 12, 2026
7 checks passed

Uh oh!

Conversation

erinepshovel-code commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

erinepshovel-code commented Sep 11, 2026

Uh oh!

erinepshovel-code commented Sep 11, 2026

Uh oh!

erinepshovel-code commented Sep 11, 2026

Uh oh!

erinepshovel-code commented Sep 11, 2026

Uh oh!

erinepshovel-code commented Sep 11, 2026

Uh oh!

erinepshovel-code commented Sep 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erinepshovel-code commented Sep 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erinepshovel-code commented Sep 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erinepshovel-code commented Sep 12, 2026

Uh oh!

erinepshovel-code commented Sep 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erinepshovel-code commented Sep 11, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Sep 11, 2026 •

edited

Loading