Skip to content

test(service): bind public audit and payment boundaries - #9

Merged
erinepshovel-code merged 4 commits into
mainfrom
repair/service-boundary-tests
Sep 14, 2026
Merged

test(service): bind public audit and payment boundaries#9
erinepshovel-code merged 4 commits into
mainfrom
repair/service-boundary-tests

Conversation

@erinepshovel-code

@erinepshovel-code erinepshovel-code commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

The public Cloud Run/payment service landed through #6#8 without service-level regression coverage, and service.py started the HTTP server at import time, preventing direct boundary tests.

This repair is deliberately local:

  • keep runtime behavior unchanged when executed as python service.py;
  • move server startup behind main() / __main__ so the module is import-safe;
  • add focused checkout tests for the supported HTTPS Git-host allowlist and routing/credential escapes;
  • add focused checkout tests that paid unlock remains bound to paid status, the exact payment-link product, USD $19 amount, and an allowlisted checkout repository;
  • keep that deployment-only test out of the library sdist because service.py is not a distributed library module;
  • replace setuptools' deprecated TOML-table project.license with the supported SPDX string form.

The first exact-head CI exposed the source/sdist boundary by failing when the sdist replay contained test_service.py but not the deployment-only service.py; this head repairs that packaging mismatch rather than expanding the published library surface.

No pricing, host policy, audit semantics, Stripe network behavior, or deployment configuration changes.

hmmm: end-to-end Stripe callback and live-host clone behavior remain integration surfaces. The repository has also advanced beyond the already-published v0.2.0 source while pyproject.toml still says 0.2.0; do not publish rebuilt artifacts under that existing version without an explicit version/release decision.

Copy link
Copy Markdown
Contributor Author

@codex review

Review exact head 4b356d93216a4f0bfb5bff2b68a4522f9b925bbd for substantive P1/P2 defects in the import-safe service boundary and local URL/payment regression tests. Scope is testability and boundary preservation only; no pricing, host policy, audit semantics, or deployment behavior should change.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-14T12:44:02.017787Z 7f4b0bb Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Contributor Author

@codex review

Review exact head 7f4b0bb62a34b04068b57c1998eaf1439aff67cc. The first CI run exposed that test_service.py was copied into the library sdist while deployment-only service.py is not; this head keeps the service regression in checkout-only scope and also replaces the deprecated setuptools license-table form with the supported SPDX string. Check for P1/P2 defects, scope leakage, and packaging/release-contract regressions.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 7f4b0bb62a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@erinepshovel-code
erinepshovel-code merged commit 0f467b8 into main Sep 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant