Skip to content

Declare the canonical parser contract for consumer reconciliation - #97

Merged
erinepshovel-code merged 3 commits into
mainfrom
repair/parser-contracts-20260912
Sep 12, 2026
Merged

erinepshovel-code merged 3 commits into
mainfrom
repair/parser-contracts-20260912

Conversation

@erinepshovel-code

@erinepshovel-code erinepshovel-code commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

The Python reference parser is executed by consumer contract audits but lacked its own module declaration and field-preservation obligation. It now declares its canonical owner and existing numeric-field behavior beside the implementation. Consumers can reconcile the exact vendored dependency and attach local evidence without taking ownership of the parser.

File plan:

Path Change and purpose Risk Required validation
msdmd/parsers/universal.py Add MODULE_BUILD/CONTRACTS; refresh ratio counts Metadata parsing of the helper itself Existing parser suite and explicit declaration assertions
tests/test_universal_parser.py Bind existing numeric-field regression to the new contract Test declaration only Full unit suite
msdmd/SKILL.md Explain exact dependency reconciliation and retained canonical ownership Narrow workflow clarification Skill compliance/index drift

No grammar, RATIOS placement, or domain semantics change. Validation: 250 unit tests pass; strict skill drift/compliance, 41 plugin adapters, strict RATIOS, llms-build drift, and all 7 RepoLOTO checks pass. Exact candidate head: 05c52aa0999ce102d9cb369434da214e91c5f421. This is the canonical prerequisite for UCNS #226's imported-parser declaration finding.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-12T04:17:42.783567Z 05c52aa Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 43e69d1c10

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/test_universal_parser.py Outdated
Comment thread msdmd/parsers/universal.py Outdated
Comment thread msdmd/parsers/universal.py Outdated
Comment thread msdmd/parsers/universal.py
@erinepshovel-code

Copy link
Copy Markdown
Contributor Author

@codex review

Review exact head 0f0346a. The four findings are fixed: CHECKS calls a no-argument module-level witness also invoked by the unittest suite; boundary fields use declared enum values; COMMENT_MARKERS is included in the public surface; a temporary file carries an observable top-level sentinel and parse_file must not execute it. All 250 unit tests and strict skill drift/compliance/RATIOS gates pass. Parser grammar and RATIOS placement remain unchanged.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0f0346ad61

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread msdmd/parsers/universal.py Outdated
@erinepshovel-code

Copy link
Copy Markdown
Contributor Author

@codex review

Please review exact head 05c52aa0999ce102d9cb369434da214e91c5f421. The sole delta declares the existing RATIO_IDS public constant alongside the other parser exports. All 250 unit tests and strict drift, compliance, and RATIOS gates pass. The implementation and witness are unchanged.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 05c52aa099

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@erinepshovel-code
erinepshovel-code merged commit 0d9bbca into main Sep 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant