Skip to content

Declare and test the TypeScript reference parser contract - #98

Merged
erinepshovel-code merged 2 commits into
mainfrom
repair/typescript-parser-contract-20260912
Sep 12, 2026
Merged

erinepshovel-code merged 2 commits into
mainfrom
repair/typescript-parser-contract-20260912

Conversation

@erinepshovel-code

Copy link
Copy Markdown
Contributor

The vendored TypeScript reference parser advertises numeric field preservation but lacked an owned contract and a direct execution witness. It now declares its complete existing public surface and field-preservation/no-execution obligation at the canonical owner.

The no-argument CHECKS witness executes the actual TypeScript helper through Node, verifies both parseText and parseFile with digit-bearing fields, and confirms that a temporary inspected source file's observable top-level write never executes. CI installs Node 24.15.0 before running the full Python-hosted test suite. Consumer guidance now covers both reference helpers.

Files: msdmd/parsers/universal.ts owns the declarations; tests/test_universal_parser.py owns the executable witness; .github/workflows/ci.yml owns its Node prerequisite; msdmd/SKILL.md preserves canonical ownership during propagation. No parser grammar or domain semantics change.

Validation: 251 unit tests pass using Node 24.15.0; strict skill drift/compliance/RATIOS, plugin adapter drift, and llms-build checks pass. Exact head 5e7239b52dc5403d8d01fbc63341fe397719ec3f. Required by UCNS #226's TypeScript parser finding; UCNS will reconcile and execute its own exact vendored dependency.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-12T04:32:53.090455Z 5e7239b Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@erinepshovel-code

Copy link
Copy Markdown
Contributor Author

@codex review

Please review exact head 5e7239b52dc5403d8d01fbc63341fe397719ec3f. The TypeScript parser now owns its complete existing export surface and numeric-field/no-execution contract. A no-argument Python CHECKS witness executes the actual TypeScript helper with Node 24.15.0, exercising both parseText and parseFile plus an observable inspected-source sentinel. All 251 tests pass and strict drift/compliance/RATIOS, plugin adapter, and llms-build gates pass. No parser grammar or geometry semantics change.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 5e7239b52d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@erinepshovel-code
erinepshovel-code merged commit da2de17 into main Sep 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant