Declare and test the TypeScript reference parser contract - #98
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review Please review exact head |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The vendored TypeScript reference parser advertises numeric field preservation but lacked an owned contract and a direct execution witness. It now declares its complete existing public surface and field-preservation/no-execution obligation at the canonical owner.
The no-argument CHECKS witness executes the actual TypeScript helper through Node, verifies both parseText and parseFile with digit-bearing fields, and confirms that a temporary inspected source file's observable top-level write never executes. CI installs Node 24.15.0 before running the full Python-hosted test suite. Consumer guidance now covers both reference helpers.
Files:
msdmd/parsers/universal.tsowns the declarations;tests/test_universal_parser.pyowns the executable witness;.github/workflows/ci.ymlowns its Node prerequisite;msdmd/SKILL.mdpreserves canonical ownership during propagation. No parser grammar or domain semantics change.Validation: 251 unit tests pass using Node 24.15.0; strict skill drift/compliance/RATIOS, plugin adapter drift, and llms-build checks pass. Exact head
5e7239b52dc5403d8d01fbc63341fe397719ec3f. Required by UCNS #226's TypeScript parser finding; UCNS will reconcile and execute its own exact vendored dependency.