Skip to content

Repair post-merge Python Gonol P1/P2 findings #39

Description

@erinepshovel-code

PR #38 merged before its exact-head Codex review completed. That review finished against e46d9273c52b4e820b1e879c06dfc0588cb8511f with five unresolved findings that remain applicable to the Python Gonol construction on current main:

  • P1: replay accepts implemented-candidate standing on a python.source.hmmm root; require successful standing to bind to a module root and hmmm standing to bind to the source-hmmm root.
  • P1: ast.parse alone admits compiler-invalid Python file inputs (for example module-level return, module-level await, misplaced from __future__); add non-executing compiler validation before assigning successful standing.
  • P2: classic-Mac \r line boundaries are not mapped correctly through the tokenizer witness; normalize the recognition view while preserving exact original source positions/bytes.
  • P2: the recognition witness checks only Python 3.12 major/minor although BASE.json pins CPython 3.12.14; enforce implementation + exact patch and pin CI accordingly.
  • P2: recursive AST span traversal can raise RecursionError on valid deep trees; use iterative traversal or otherwise preserve valid deep file inputs.

Repair only these live findings. Preserve tokenizer/AST/compiler objects as recognition witnesses, never gonol identities; preserve invalid input under hmmm; add one focused regression per finding; run Python Gonol and stack-consistency gates; require exact-head review before merge.

hmmm: exact UCNS affixiation geometry remains outside this repair.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions