Skip to content

feat(layer): add canonical composer query preview widget - #129

Merged
pcharbon70 merged 1 commit into
mainfrom
claude/widget-composer-inline-ask-wave-3-7-b
May 20, 2026
Merged

pcharbon70 merged 1 commit into
mainfrom
claude/widget-composer-inline-ask-wave-3-7-b

Conversation

@ty13r

@ty13r ty13r commented May 18, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Rebases feat(layer): add canonical composer query preview widget #129 onto main and replaces the product-specific composer_inline_ask shape with canonical composer_query_preview.
  • Registers the widget as a first-class :layer_shell_and_callout primitive across unified_iur, unified_ui, live_ui, Ash UI adapters, authoring validation, docs, and specs.
  • Uses canonical UnifiedIUR.Interaction transport for dismiss/open/save actions; renderer-only phx-* attrs are generated at the Live UI boundary.
  • Keeps the preview as a sibling primitive above/near a composer, not a chat_composer slot.

Architecture Decisions

  • Canonical name: composer_query_preview, with no repo/product-specific names in the canonical contract.
  • Trigger model: parent/runtime owns data flow and mounts the preview with state; no imperative product-specific helper is required here.
  • Finding IDs: opaque id values in canonical output; old finding_id input is normalized only for compatibility.
  • Actions: dismiss/open/save are canonical interactions (:close, :open, :command) instead of on_* callback fields.
  • Shortcut/UI hints: not canonicalized as product constants; renderers can decide presentation locally.
  • Family: :layer_shell_and_callout, matching the existing rail/callout primitives.

Verification

  • mix format --check-formatted on touched Elixir files
  • Focused canonical widget test set: 90 tests, 0 failures
  • Spec-listed Ash UI boundary/adapter tests: 51 tests, 0 failures
  • Renderer/docs/admission tests: 46 tests, 0 failures
  • bash ./scripts/validate_specs_governance.sh
  • bash ./scripts/validate_guides_governance.sh
  • bash ./scripts/validate_code_docs.sh
  • git diff --check -- . ':(exclude)_build/**' ':(exclude)deps/**'

Notes

  • mix spec.next is not wired in this checkout (The task "spec.next" could not be found).
  • Bare mix format --check-formatted still requires explicit files/patterns in this repo; the touched-file format check passed.
  • Full mix test ran 1059 tests with 1 existing unrelated failure: missing traceability matrix entry for REQ-WFPS-006 in AshUI.Phase8IntegrationTest.

@pcharbon70
pcharbon70 force-pushed the claude/widget-composer-inline-ask-wave-3-7-b branch from 0caf2df to e08199a Compare May 20, 2026 14:56
@pcharbon70 pcharbon70 changed the title feat(live_ui): add ComposerInlineAsk widget Phoenix.Component (Wave 3.7-B Stage-4, DRAFT, Pascal-review REQUIRED) feat(layer): add canonical composer query preview widget May 20, 2026
@pcharbon70
pcharbon70 marked this pull request as ready for review May 20, 2026 14:57
@pcharbon70
pcharbon70 merged commit c960fac into main May 20, 2026
7 of 8 checks passed
@pcharbon70
pcharbon70 deleted the claude/widget-composer-inline-ask-wave-3-7-b branch May 20, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants