Repository navigation
[P2][Tier-1] markdown_viewer mode attr silently dropped (reserved :mode key) (audit C4) #193
Description
Activity
Codex cross-validation (2026-05-28): the same
:modedrop also affects canonical OVERLAYS — the renderer passes overlay mode (renderer.ex:953-960) butOverlaySurfaceexpects@modefor data-live-ui-mode (overlay_surface.ex:10-29). Fix both surfaces together.
Severity: P2 (renderer work that can't land) · Tier-1 (mechanical rename)
Co-maintained repo (Pascal = architect).
Location:
packages/live_ui/lib/live_ui/widget.ex:153(drops:mode);renderer.ex:736The renderer passes
mode={... [:document, :mode] ...}toMarkdownViewer, butLiveUi.Widget.build_render_assigns/1Map.drops:mode(reserved key), soMarkdownViewer.render/1always falls back toattr :mode default: "rendered". The IUR's[:document, :mode]("raw"/"source") never takes effect.Fix: rename the markdown attr to a non-reserved name (e.g.
:view_mode/:format) on both the renderer call and the component; verify no other widget relies on:mode.2026-05-28 cross-repo review — see ariston-ui
docs/audits/cross-repo-review-2026-05-28.md(finding C4).