Skip to content

[P2][Tier-1] BrowserBridge.normalize_key creates unbounded atoms (atom-table DoS, latent) (audit C5) #194

Description

@ty13r

Severity: P2 (latent atom-table DoS) · Tier-1 (mechanical)
Co-maintained repo (Pascal = architect).
Location: packages/live_ui/lib/live_ui/runtime/browser_bridge.ex:89-95

normalize_key/1 does String.to_existing_atom(binary) with a rescue ArgumentError -> String.to_atom(binary) fallback over EVERY key of an incoming hook payload (normalize_map/1), before take_keys/2 filters to the allowlist. Mitigated today (module is a placeholder, authoritative?() == false, not wired to a concrete channel handle_in), so latent — but a DoS vector once the bridge goes authoritative.

Fix: drop the String.to_atom fallback — discard keys not in the allowlist rather than interning them.

2026-05-28 cross-repo review — see ariston-ui docs/audits/cross-repo-review-2026-05-28.md (finding C5).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions