Skip to content

[P3][Tier-1] tree_view does not gate child visibility on expanded? (audit C7) #196

Description

@ty13r

Severity: P3 (semantic gotcha) · Tier-1
Co-maintained repo (Pascal = architect).
Location: packages/live_ui/lib/live_ui/widgets/tree_view.ex:46-52

Children always render (the if only checks children presence); expanded? only sets a data-expanded attribute. No <details>/hidden/collapse and no in-repo CSS to enforce it, so a "collapsed" node still shows all descendants. Contrast Disclosure (content_identity.ex:84), which uses native <details open={@open}>.

Fix: gate the child <ul> on expanded?, or render via <details>.

2026-05-28 cross-repo review — see ariston-ui docs/audits/cross-repo-review-2026-05-28.md (finding C7).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions