Repository navigation
Conversation
updated CTS setup rules Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request reduces the clock period for the CVA6 design on ASAP7 from 1000 ps to 850 ps and relaxes several timing regression rules to accommodate the resulting timing violations. The reviewer feedback highlights that these changes introduce significant timing violations (with setup worst slack degrading to -101.0 ps and total negative slack to -7140.0 ps at the finish stage), meaning the design does not actually meet timing at the new frequency. It is recommended to either optimize the physical design flow to resolve these violations or revert to a more conservative clock period rather than relaxing the regression rules.
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check. Commit 62 design(s) checked — 1 with regression(s), 0 without a comparable baseline.
❌ asap7/cva6 base — 6 failing metric(s)
|
Contributor
Author
|
Lucas already updated it to 910ps |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finish setup WNS now negative (reduced clock period from 1000 to 850)