Repository navigation
ci: test setup.sh local installation path - #4519
Open
GITTYCAT12 wants to merge 1 commit into
Open
GITTYCAT12 wants to merge 1 commit into
GITTYCAT12 wants to merge 1 commit into
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds CI coverage for the host-local installation path through
setup.sh.The existing installer workflow exercises
DependencyInstaller.shthrough Docker, but it does not execute the user-facingsetup.shpath directly. This can allow regressions in setup-specific behavior to go unnoticed.This PR adds an Ubuntu 22.04 job that:
sudo ./setup.sh./build_openroad.sh --localenv.shand verifies the resultingyosysandopenroadinstallationsIt also makes changes to the workflow itself trigger the installer workflow and explicitly includes
setup.shin the path filters.This addresses the intent of upstream issue #4453 without changing the production flow or installer implementation.