Repository navigation
add gcd to gf180 - #4756
add gcd to gf180#4756maliberty merged 1 commit into
Conversation
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the configuration and constraint files for the GCD design on the GF180 platform. The review feedback points out two critical issues: the use of an undefined variable $(DESIGN_HOME) in config.mk which will lead to build failures, and an overly aggressive clock period of 3ns in constraint.sdc that is unrealistic for the 180nm technology node and should be increased to ensure timing closure.
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 9 with regression(s), 1 without a comparable baseline. ❌ asap7/ethmac_lvt base — 1 failing metric(s)
❌ asap7/gcd base — 1 failing metric(s)
❌ asap7/mock-alu base — 2 failing metric(s)
❌ asap7/riscv32i base — 1 failing metric(s)
❌ gt2n/aes base — 2 failing metric(s)
❌ gt2n/jpeg base — 1 failing metric(s)
❌ nangate45/bp_fe_top base — 1 failing metric(s)
❌ sky130hd/chameleon base — 1 failing metric(s)
❌ sky130hs/gcd base — 2 failing metric(s)
|
0fcc418
into
The-OpenROAD-Project:master
No description provided.