Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors spreadsheet_ram.py by removing unused imports, the main driver, and several core methods including create_memory, read_physical_file, get_size_keys, and read_metrics_file. Additionally, it deletes several spreadsheet-related flow test files. The review feedback recommends further cleanup of now-obsolete components in SSRAMGenerator, such as self._process, self._pin_type_map, _import_custom_mappings, and their associated imports, to complete the pruning process.
code review feedback reformatting Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
5427bbf to
e7265e8
Compare
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 1 without a comparable baseline. |
|
pr-head failing due to GH hash issue with slang @maliberty neither should be related to changes in FakeRAM. Please merge. |
75cd896
into
The-OpenROAD-Project:master
The spreadsheet-based RAM generation has been updated to support direct data extraction, as opposed the CSV approach. Pruned out obsolete code.