Skip to content

Enabled read_saif/read_vcd via flow variables - #4768

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:enable-vcd-saif-2
Oct 29, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:enable-vcd-saif-2

Conversation

@jeffng-or

Copy link
Copy Markdown
Contributor

Attempt #2. Hopefully yamlfix doesn't try changing the stages attributes again

Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
@jeffng-or jeffng-or self-assigned this Oct 29, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for SAIF and VCD files to annotate switching activity for power calculations. It introduces three new flow variables (POWER_FILE_SCOPE, SAIF_FILE, and VCD_FILE), documents them, and updates the report_metrics.tcl script to read these files and report activity annotations. The reviewer suggests redirecting the output of report_activity_annotation to the report file ($filename) instead of stdout to ensure the annotation report is properly captured.

Comment thread flow/scripts/report_metrics.tcl
@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit e022e38 · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 1 without a comparable baseline.

@jeffng-or

Copy link
Copy Markdown
Contributor Author

Both failures are in swerv-wrapper, so not related to this change.

@maliberty, please merge.

@maliberty
maliberty merged commit f274d5d into The-OpenROAD-Project:master Oct 29, 2026
10 of 12 checks passed
@maliberty
maliberty deleted the enable-vcd-saif-2 branch October 29, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants