Repository navigation
dogfooding: test generated logic by constant propagation - #1197
Merged
Merged
Conversation
Rule 5 says to test intended behaviour rather than golden output; this adds how, for generated logic, without a simulator: case analysis on the inputs and storage, sta::pin_sim_logic_value on the outputs, OpenSTA's constant propagation between. The worked example is OpenROAD#11669's register-file tests, each with a negative control. And a pitfall: tee -variable runs its script unsubstituted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dogfoodingrule 5 says a public PR's test checks intended behaviour, not golden output. This adds how, for generated logic, without a simulator: case analysis on the inputs and the storage,sta::pin_sim_logic_valueon the outputs, and OpenSTA's constant propagation through the cells in between.The worked example is The-OpenROAD-Project/OpenROAD#11669
src/ram/test/regfile_checks.tcl: reads, writes, clock gates, both reset polarities and write priority, each with a negative control that fails. Plus one pitfall:tee -variableruns its script unsubstituted.🤖 Generated with Claude Code