Skip to content

upstream-pr: from carried patches to an upstream pull request - #1198

Merged
oharboe merged 1 commit into
mainfrom
skills/upstream-pr
Oct 8, 2026
Merged

oharboe merged 1 commit into
mainfrom
skills/upstream-pr

Conversation

@oharboe

@oharboe oharboe commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

A new skill, upstream-pr, for after the human orders an upstream pull request (the moratorium in CLAUDE.md is unchanged): how carried patches become a pull request a maintainer can review.

  • one commit per concern, built from snapshots of the final tree, each passing its own tests;
  • written for the upstream reader: no carried patch numbers or bazel-orfs bookkeeping, the number first, one link to the integration-test PR;
  • lint at the versions upstream's CI pins, and generated files equal to their generator;
  • a draft, force-pushed only until it is ready for review, then fast-forward only;
  • every review-bot comment verified, answered taken or not taken, and resolved; no silent fallbacks.

Learned filing The-OpenROAD-Project/OpenROAD#11669 and The-OpenROAD-Project/OpenROAD-flow-scripts#4649, #4650 and #4651.

🤖 Generated with Claude Code

A new skill for after the human orders an upstream pull request: one
commit per concern built from snapshots, written for the upstream reader
without bazel-orfs bookkeeping, linted at upstream's pinned versions with
generated files equal to their generator, a draft force-pushed only until
it is ready for review, and every review-bot comment verified, answered
taken or not taken, and resolved. Learned filing OpenROAD#11669 and
ORFS#4649/#4650/#4651.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
@oharboe
oharboe merged commit f4a1b67 into main Oct 8, 2026
1 check passed
@oharboe
oharboe deleted the skills/upstream-pr branch October 8, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant