Repository navigation
orfs: SKIP_REPORT_METRICS keeps the free metrics, and is the default - #1433
Merged
Merged
Conversation
Before, a flow either paid for a timing update, a power analysis and the text reports at every stage, or lost every report_metrics metric, design area and instance counts included. Now SKIP_REPORT_METRICS=1 still writes the metrics that cost nothing, and it is bazel-orfs's default; a flow sets "0" for timing and power in its stage .json. 0157 writes report_design_area_metrics before the skip and runs the calls that cost time even on gcd under log_cmd, so a slow one names itself in the log. 0158 flips the variables.yaml default. No new variable. gcd on asap7 gives byte-identical .odb files at every stage with the metrics on (DETAILED_METRICS=1) and off. test/regfile/macro's RegFile flow sets SKIP_REPORT_METRICS=0: floor_cycles_test reads grt's fmax metric. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, a flow either paid for a timing update, a power analysis and the text reports at every stage, or lost every
report_metricsmetric, design area and instance counts included.Now
SKIP_REPORT_METRICS=1still writes the metrics that cost nothing, and it is bazel-orfs's default; a flow sets"0"for timing and power in its stage.json. No new variable.report_design_area_metricsruns before the skip. The calls that cost time even on gcd run underlog_cmd, so a slow one names itself in the log (Took N seconds, from 5 s). The four register path searches go throughlog_cmd eval { ... }, so the log shows the command, not the register list.variables.yamldefault 0 → 1.test/regfile/macroRegFile setsSKIP_REPORT_METRICS=0:floor_cycles_testreads grt's fmax metric.Side effects on QoR
gcd on asap7, metrics on (
DETAILED_METRICS=1, so the mid-stage reports in cts and grt run too) vs off: every stage's.odband6_final.vare byte-identical, before and after the patch.Always written
report_metrics)Skipped by default: cost on gcd (ms, summed per stage)
log_cmdreport_powerreport_tns(the timing update)find_timing_paths×2eval)report_checks×2eval)report_erc_metricsreport_check_typesreport_clock_min_periodreport_clock_skew,report_wns,report_worst_slack, unfilteredreport_checks, other*_metricMeasured once with a timing patch that is not carried. tclint not run; the edit follows its rules (100 columns, spaces in braces).
🤖 Generated with Claude Code